search

ropensci / vcr

Record and replay HTTP requests
https://docs.ropensci.org/vcr
Other
77 stars 12 forks source link

should vcr::use_vcr() add a dependency on vcr current version #214

Closed maelle closed 3 years ago

maelle commented 3 years ago

I.e. right now it adds "vcr" under Suggests but shouldn't it add "vcr ( >= 0.6.0)" as dependency, or whatever the current version is?

sckott commented 3 years ago

Hmm, maybe. I guess it depends on the features of the pkg one is using, right?

maelle commented 3 years ago

Well there is vcr::vcr_test_path() used in the setup file and not available in previous versions

sckott commented 3 years ago

Right, if use_vcr is adding vcr_test_path then yeah should have min v0.6. But I forget, are Suggests pkg versions respected when installing a pkg, running check?

maelle commented 3 years ago

I would hope so 🤔

sckott commented 3 years ago

We'll have to use the last version on CRAN for this. Will need to be updated manually as we don't want to have an http request to get the version that might fail