search

ropensci / vcr

Record HTTP calls and replay them
https://docs.ropensci.org/vcr
Other
77 stars 12 forks source link

include tinytest tesing -- BASIC SETUP ONLY #250

Closed jimrothstein closed 1 year ago

jimrothstein commented 1 year ago

Description

This is TEST only. Not Real PR.

basic setup for tinytest::

Related Issue

first step in #162

Example

Goal: Add tests of the form tinytest::expect_equal(1+1, 2) and similar.

sckott commented 1 year ago

thanks @jimrothstein - want me to do anything? i just approved it so the checks can run

jimrothstein commented 1 year ago

@sckott Thx. Will continue now with a few tests, just wanted you to take look.
Before I get too far, will ask you to take another look .... Thanks.

jimrothstein commented 1 year ago

Will do..

On Tue, Nov 8, 2022, 2:07 PM Scott Chamberlain @.***> wrote:

@.**** commented on this pull request.

In DESCRIPTION https://github.com/ropensci/vcr/pull/250#discussion_r1017160251:

@@ -48,8 +47,9 @@ Suggests: crayon, cli, curl,

  • withr
  • withr, tinytest

please do put imports each on a new line

— Reply to this email directly, view it on GitHub https://github.com/ropensci/vcr/pull/250#pullrequestreview-1172907564, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB6BJ75D5JWOR7M7ZL7P3GLWHLFIZANCNFSM6AAAAAARY2W7FM . You are receiving this because you were mentioned.Message ID: @.***>

jimrothstein commented 1 year ago

@sckott Apologies ... gotten myself fouled up with git. Can you delete this entire branch "jim" ? I want start over.

sckott commented 1 year ago

@jimrothstein that branch is in your fork of the repo, not mine 😄