ropensci / vcr

Record HTTP calls and replay them
https://docs.ropensci.org/vcr
Other
77 stars 12 forks source link

CRAN check problem for at least two packages #251

Closed maelle closed 1 year ago

maelle commented 1 year ago

https://cran.r-project.org/web/checks/check_results_nasapower.html

maelle commented 1 year ago

https://cran.r-project.org/web/checks/check_results_rtweet.html

llrs commented 1 year ago

rtweet has the same error than reported in #249. So, I think the problem might be more general than just two packages and might be fixed with a new update to vcr in CRAN

maelle commented 1 year ago

On GitHub Actions and locally there's a vcr failure for nasapower tests that do not use vcr https://github.com/ropensci/nasapower/actions/runs/3398663485/jobs/5651901782

See also https://github.com/ropensci/nasapower/pull/73#issuecomment-1305210144

KevCaz commented 1 year ago

Same error in rcites and rmangal.

sckott commented 1 year ago

Thanks @maelle ! I'm aware of the situation. Various issues to fix - already getting help from folks

jhnwllr commented 1 year ago

rgbif is still having problems https://cran.r-project.org/web/checks/check_results_rgbif.html

llrs commented 1 year ago

@jhnwllr the issue is not fixed in CRAN yet. Until the fix in vcr is in CRAN or we modify our packages, they will continue failing. Could you check that #252 solves the problem in your local computer ? If it does it is "just" a matter of time to get it merged and in CRAN to prevent this problems

sckott commented 1 year ago

@jhnwllr we're still working on fixes. I'll get in touch via email and we'll update the issues here when we have fixes in place

bretsw commented 1 year ago

I've been following the various vcr issues threads the past week. I know you all are working on this, so thank you!

I wanted to let you know this is also an issue for tidytags; one test throws the same error (https://cran.r-project.org/web/checks/check_results_tidytags.html) as has been reported for the other packages in this thread.

My question for more experienced package developers: (@sckott @maelle @llrs ) I received the "Please correct before 2022-11-20 to safely retain your package on CRAN." email from CRAN. Any advice on how I should respond to them to keep tidytags up on CRAN in the interim?

Again, many thanks!

sckott commented 1 year ago

thanks @bretsw for dropping in here. Since I've been in touch with CRAN, and let them know we're working on the fixes, they will probably give more time than the date they gave you, but I'm not 100% sure about that. You could respond and say that it's not a problem with your package and that you've been told a fix is coming that should resolve the check failures.

llrs commented 1 year ago

@sckott I already sent an email to CRAN about this situation ~5 days ago pointing to the PR I submitted and got this reply:

Thanks. The vcr maintainer promised a fix for some of these problems soon, so let's wait and hope for the best :-)

@bretsw I hope to submit a new rtweet version to CRAN soon to include some needed improvements. If vcr is not fixed by the 20th, or there isn't any new deadline, I would submit a new version of rtweet skipping all test with vcr in CRAN (if I fix some remaining issues for this release). This way I might avoid rtweet to be removed from CRAN and thus tidytags.

jhnwllr commented 1 year ago

Running the dev version of vcr remotes::install_github("ropensci/vcr") fixes the test failures for rgbif.

sckott commented 1 year ago

thanks @llrs for the update

@jhnwllr great, glad it works for you!

sckott commented 1 year ago

we're almost ready to submit, closing this issue