search

ropensci / vcr

Record HTTP calls and replay them
https://docs.ropensci.org/vcr
Other
77 stars 12 forks source link

setup-vcr.R -> helper-vcr.R #256

Closed dpprdan closed 1 year ago

dpprdan commented 1 year ago

This changes all references to setup-vcr.R to helper-vcr.R, as discussed in #244. use_vcr() also now creates a helper-vcr.R file.

cc @maelle

dpprdan commented 1 year ago

I haven't rendered the README or the vignettes to avoid potential merge conflicts. Rendering the README also resulted in a lot of unrelated changes for me.

sckott commented 1 year ago

thanks @dpprdan

@maelle can you take a look at this PR?

Do you think we should put this in this upcoming version to be submitted to CRAN? Or wait until the next version?

maelle commented 1 year ago

I can't take a closer look before Thursday but definitely agree on the principle!

sckott commented 1 year ago

@maelle okay, thanks. I'll see where I'm at wrt being ready to submit. If I'm ready to submit I don't want to wait too long as there's lots of pkg maintainers getting anxious about their pkgs being archived.