search

ropensci / visdat

Preliminary Exploratory Visualisation of Data
https://docs.ropensci.org/visdat/
Other
450 stars 47 forks source link

Use rOpenSci pkgdown template? #115

Closed maelle closed 5 years ago

maelle commented 5 years ago

:wave: here! Would you be interested in using rOpenSci pkgdown template for your package doco (I've just learnt this word by seeing the latest commit to your pkgdown config :grin: )? See https://ropensci.github.io/rotemplate/ The package and its guidance are brand-new, so comments welcome.

njtierney commented 5 years ago

Yes that sounds wonderful!

njtierney commented 5 years ago

Although it looks like I don't quite get the changes - the blue banner has dissappeared, but when run locally I got the nice blue banner:

image

Any thoughts?

the rotemplate was easy to set up! I've got a few minor suggestions for improving readability of the README in a PR that should be incoming soon.

maelle commented 5 years ago

ah weird! do you think it could be due to the doc search? your website is the first one we apply the template to that has doc search so that might be the issue? I'll investigate!

maelle commented 5 years ago

Can you try again with the new version of the rotemplate package? I only changed the order of the CSS lines in head.html. It's very puzzling that the website looks different locally, and then online you get no rOpenSci styling at all.

maelle commented 5 years ago

Even the favicon disappeared in the online version!

maelle commented 5 years ago

changing the order did nothing in my fork :thinking: