search

ropensci / visdat

Preliminary Exploratory Visualisation of Data
https://docs.ropensci.org/visdat/
Other
450 stars 47 forks source link

Fix website #116

Closed maelle closed 5 years ago

maelle commented 5 years ago

I changed the order of JS/CSS but the most important thing of this PR to fix #115, that you can implement without merging my PR, is to remove docs/ from .gitignore, so that ropensci.css gets uploaded. :-)

Any reason why not trying Travis deploy btw?

njtierney commented 5 years ago

Thank you! It works!

njtierney commented 5 years ago

Any reason why not trying Travis deploy btw?

I thought I had triggered this, as I used:

use_pkgdown_travis()

And I thought that this line in .travis.yml made this happen - but I'm actually not sure how to check if I've got the travis thing set up right?

I guess at the moment maybe it isn't running because I keep getting build errors, which I think has something to do with a vdiffr?

maelle commented 5 years ago

I guess at the moment maybe it isn't running because I keep getting build errors, which I think has something to do with a vdiffr?

Yes you'd need the rest of the build to work first. I'll have a look next week.