Closed zeehio closed 1 year ago
Hello!
This is a very lovely PR - thank you so much for taking the time to detail it out as you have!
This catches a new bug, and I'm really grateful that you've caught it and also given a nice elegant solution 😄
I can do these things if you would prefer (and am happy to!) but would you be able to add the following:
Thank you again!
Thanks I will make those changes (and using "<1%" looks better than "0.3%" so I will change that as well).
It's been a busy week, I will try to get this done either today or next week.
Have a great weekend!
Done. Feel free to merge :+1:
Marvellous, thank you!
Thanks for this package. I find the labelling of column percentages inconsistent when the percentage is between 0.1 and 0.5%.
Here is a reproducible example of the issue, with a plot. Please compare the
miss_0.2
label with the labels next to it:Created on 2023-02-28 with reprex v2.0.2
Before:
Issue: The behaviour of percentages between 0.1% and 0.5% is confusing. For instance, a percentage of "0.2%" appeared rounded to units, and was labelled as "0%", as if no missing values were found.
Solution:
An alternative to this solution is to choose that percentages <1% become "<1%". That would also be a good solution. If you prefer that feel free to say so or just commit the change and merge at will.
With this pull request applied:
Created on 2023-02-28 with reprex v2.0.2