ropensci / visdat

Preliminary Exploratory Visualisation of Data
https://docs.ropensci.org/visdat/
Other
453 stars 47 forks source link

Minor wording changes to README and vignettes #37

Closed seaaan closed 7 years ago

seaaan commented 7 years ago

Suggested changes and typo corrections that are easy to point out this way than by describing in my review for rOpenSci. The review will appear here once it's complete.

codecov-io commented 7 years ago

Current coverage is 99.24% (diff: 100%)

Merging #37 into master will not change coverage

@@             master        #37   diff @@
==========================================
  Files             9          9          
  Lines           265        265          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            263        263          
  Misses            2          2          
  Partials          0          0          

Powered by Codecov. Last update 18a082d...b3cafe7

njtierney commented 7 years ago

Thank you @seaaan ! Very happy with these suggestions, thank you for taking the time to do this. Should I wait until the review is complete to merge these chances?

seaaan commented 7 years ago

No need to wait. The review is almost done, hopefully by the end of the weekend.

On Saturday, January 14, 2017, Nicholas Tierney notifications@github.com wrote:

Thank you @seaaan https://github.com/seaaan ! Very happy with these suggestions, thank you for taking the time to do this. Should I wait until the review is complete to merge these chances?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/njtierney/visdat/pull/37#issuecomment-272665638, or mute the thread https://github.com/notifications/unsubscribe-auth/AKDNdTfbb6M5F1yj_K1HOIv7Fj0U-dHVks5rSXBdgaJpZM4LjwgQ .

njtierney commented 7 years ago

Thank you very much @seaaan! :)