search

ropensci / visdat

Preliminary Exploratory Visualisation of Data
https://docs.ropensci.org/visdat/
Other
450 stars 47 forks source link

vis_miss % is NA when the percentage is very small #71

Closed sfirke closed 6 years ago

sfirke commented 6 years ago 
x <- babynames::babynames %>% slice(1:1000)
x$new <- 1
x$new[nrow(x)] <- NA
vis_miss(x)

The final column has new (NA) instead of new <1% or new 1% which is what I'd expect.

njtierney commented 6 years ago

Heya Sam,

Thanks for posting - I think this is a duplicate of #62 which is now fixed in the dev version - see below:

library(tidyverse)
library(visdat)
x <- babynames::babynames %>% slice(1:1000)
x$new <- 1
x$new[nrow(x)] <- NA
vis_miss(x)

Created on 2018-03-29 by the reprex package (v0.2.0).

Session info ``` r devtools::session_info() #> Session info ------------------------------------------------------------- #> setting value #> version R version 3.4.4 (2018-03-15) #> system x86_64, darwin15.6.0 #> ui X11 #> language (EN) #> collate en_AU.UTF-8 #> tz Australia/Melbourne #> date 2018-03-29 #> Packages ----------------------------------------------------------------- #> package * version date source #> assertthat 0.2.0 2017-04-11 CRAN (R 3.4.0) #> babynames 0.3.0 2017-04-14 CRAN (R 3.4.0) #> backports 1.1.2 2017-12-13 CRAN (R 3.4.3) #> base * 3.4.4 2018-03-15 local #> bindr 0.1.1 2018-03-13 CRAN (R 3.4.4) #> bindrcpp * 0.2 2017-06-17 CRAN (R 3.4.0) #> broom 0.4.3 2017-11-20 CRAN (R 3.4.2) #> cellranger 1.1.0 2016-07-27 CRAN (R 3.4.0) #> cli 1.0.0 2017-11-05 CRAN (R 3.4.2) #> colorspace 1.3-2 2016-12-14 CRAN (R 3.4.0) #> compiler 3.4.4 2018-03-15 local #> crayon 1.3.4 2018-03-01 Github (gaborcsardi/crayon@95b3eae) #> curl 3.1 2017-12-12 CRAN (R 3.4.3) #> datasets * 3.4.4 2018-03-15 local #> devtools 1.13.5 2018-02-18 cran (@1.13.5) #> digest 0.6.15 2018-01-28 CRAN (R 3.4.3) #> dplyr * 0.7.4 2017-09-28 CRAN (R 3.4.2) #> evaluate 0.10.1 2017-06-24 cran (@0.10.1) #> forcats * 0.3.0 2018-02-19 CRAN (R 3.4.3) #> foreign 0.8-69 2017-06-22 CRAN (R 3.4.4) #> ggplot2 * 2.2.1 2016-12-30 CRAN (R 3.4.0) #> glue 1.2.0 2017-10-29 cran (@1.2.0) #> graphics * 3.4.4 2018-03-15 local #> grDevices * 3.4.4 2018-03-15 local #> grid 3.4.4 2018-03-15 local #> gtable 0.2.0 2016-02-26 CRAN (R 3.4.0) #> haven 1.1.1 2018-01-18 CRAN (R 3.4.3) #> hms 0.4.2 2018-03-10 CRAN (R 3.4.4) #> htmltools 0.3.6 2017-04-28 cran (@0.3.6) #> httr 1.3.1 2017-08-20 CRAN (R 3.4.1) #> jsonlite 1.5 2017-06-01 CRAN (R 3.4.0) #> knitr 1.20 2018-02-20 CRAN (R 3.4.3) #> labeling 0.3 2014-08-23 CRAN (R 3.4.0) #> lattice 0.20-35 2017-03-25 CRAN (R 3.4.4) #> lazyeval 0.2.1 2017-10-29 cran (@0.2.1) #> lubridate 1.7.3 2018-02-27 CRAN (R 3.4.3) #> magrittr 1.5 2014-11-22 CRAN (R 3.4.0) #> memoise 1.1.0 2017-04-21 CRAN (R 3.4.0) #> methods * 3.4.4 2018-03-15 local #> mime 0.5 2016-07-07 CRAN (R 3.4.0) #> mnormt 1.5-5 2016-10-15 CRAN (R 3.4.0) #> modelr 0.1.1 2017-07-24 CRAN (R 3.4.1) #> munsell 0.4.3 2016-02-13 CRAN (R 3.4.0) #> nlme 3.1-131.1 2018-02-16 CRAN (R 3.4.4) #> parallel 3.4.4 2018-03-15 local #> pillar 1.2.1 2018-02-27 CRAN (R 3.4.3) #> pkgconfig 2.0.1 2017-03-21 cran (@2.0.1) #> plyr 1.8.4 2016-06-08 CRAN (R 3.4.0) #> psych 1.7.8 2017-09-09 CRAN (R 3.4.3) #> purrr * 0.2.4 2017-10-18 cran (@0.2.4) #> R6 2.2.2 2017-06-17 cran (@2.2.2) #> Rcpp 0.12.16 2018-03-13 cran (@0.12.16) #> readr * 1.1.1 2017-05-16 cran (@1.1.1) #> readxl 1.0.0 2017-04-18 CRAN (R 3.4.0) #> reshape2 1.4.3 2017-12-11 CRAN (R 3.4.3) #> rlang 0.2.0 2018-02-20 CRAN (R 3.4.3) #> rmarkdown 1.9 2018-03-01 CRAN (R 3.4.3) #> rprojroot 1.3-2 2018-01-03 CRAN (R 3.4.3) #> rvest 0.3.2 2016-06-17 CRAN (R 3.4.0) #> scales 0.5.0.9000 2017-12-06 Github (hadley/scales@d767915) #> stats * 3.4.4 2018-03-15 local #> stringi 1.1.7 2018-03-12 cran (@1.1.7) #> stringr * 1.3.0 2018-02-19 CRAN (R 3.4.3) #> tibble * 1.4.2 2018-01-22 CRAN (R 3.4.3) #> tidyr * 0.8.0 2018-01-29 CRAN (R 3.4.3) #> tidyselect 0.2.4 2018-02-26 CRAN (R 3.4.3) #> tidyverse * 1.2.1.9001 2018-03-27 local #> tools 3.4.4 2018-03-15 local #> utils * 3.4.4 2018-03-15 local #> visdat * 0.2.2.9200 2018-03-20 local #> withr 2.1.2 2018-03-15 CRAN (R 3.4.4) #> xml2 1.2.0 2018-01-24 CRAN (R 3.4.3) #> yaml 2.1.18 2018-03-08 cran (@2.1.18) ```

Does that work for you?

sfirke commented 6 years ago

It does! Dev version does not generate this error. Sorry for the duplicate issue & thanks for the quick reply.

njtierney commented 6 years ago

Hooray!

Absolutely no problems re duplicate issue, it reminds me that I should get the next version of visdat out soon.

Thanks for posting :)