fixes for vis_expect - Githubissues

ropensci / visdat

Preliminary Exploratory Visualisation of Data

https://docs.ropensci.org/visdat/

Other

450 stars 47 forks source link

fixes for vis_expect #73

Closed njtierney closed 6 years ago

njtierney commented 6 years ago

Need to add:

[x] % of cases that the expectation is TRUE (a la vis_miss) ~- [ ] Maybe add in the % of cases true in each column?~
[x] Tests for expect_frame
[x] Flesh out documentation for expect_frame
[ ] Add expect_frame into vignette (Along with vis_cor()

njtierney commented 6 years ago

Here is the current behaviour (as of commit https://github.com/ropensci/visdat/commit/be1fdf64f1911bb9cf8a4413e52282cd7dd5bc0d)

library(visdat)
dat_test <- tibble::tribble(
            ~x, ~y,
            -1,  "A",
            0,  "B",
            1,  "C"
            )

vis_expect(dat_test,
           ~ .x == -1)

vis_expect(airquality,
           ~ .x == 5.1)

Created on 2018-06-04 by the reprex package (v0.2.0).

njtierney commented 6 years ago

At the moment I am deciding to leave out the percentages of expectations that are TRUE in each column, I think you would be better off getting this kind of information from a dataframe summary method - as discussed in #83

I am going to keep the NA values as grey for the moment, but these might need to change in the future.