ropensci / wateRinfo

R package to download time series data from waterinfo.be
https://docs.ropensci.org/wateRinfo
MIT License
14 stars 3 forks source link

Hotfix dates #19

Closed stijnvanhoey closed 6 years ago

stijnvanhoey commented 6 years ago

start and end dates to download can sometimes be parsed, but representing not an actual date, e.g. "2017-11-31". For these functions, the output was NA instead of FALSE, resulting in unclear error messages.

This hot fix solves this issue, adds testing and provides docs.

stijnvanhoey commented 6 years ago

The OS checks are not starting, windows and linux checks are successfull, merging here.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.8%) to 91.586% when pulling f3d4b8b3e1b33b2396e8d0965889688877e9c458 on hotfix-dates into ee67fdc75da5a793140709ee96d6105b8c293ea2 on master.