search

ropensci / wateRinfo

R package to download time series data from waterinfo.be
https://docs.ropensci.org/wateRinfo
MIT License
14 stars 3 forks source link

suggestion: apply INBO styling #43

Closed ThierryO closed 5 years ago

ThierryO commented 6 years ago

See https://inbo.github.io/INBOtheme/. I'm happy to send a PR.

stijnvanhoey commented 6 years ago

Thanks for the suggestion. As the package itself does not have any plot-functions, plots are only created within the vignettes/examples/readme.

The scope of the wateRinfo package is to support a user community beyond INBO, so I rather keep it to the default ggplot2 styling as the plots currently are (except of the x datetime scaling). As such, new users do not have the additional cognitive load with respect to theming options (although I understand the latter is limited with just an added line of code + theme_inbo(), the effect this has on their plot will be more difficult to grasp).

On the technical side, this would introduce an additional (non-CRAN) dependency for this package build process, which I rather keep as low as possible.

Appreciate your intention, but I'm going to close the issue.

ThierryO commented 6 years ago

My suggestion was not phrased very well. I'm suggesting to use a custom css with INBO style for the the pkgdown website of wateRinfo. As I did with the INBOtheme pkgdown website. Using a uniform css for all our pkgdown websites would improve the visibility of INBO.

stijnvanhoey commented 6 years ago

Aha, I understand.

I leave the necessity, potential benefits and eventually providing custom css to @peterdesmet who is much more experienced in front-end matter.

Notice:

stijnvanhoey commented 5 years ago

As wateRinfo is now part of the ropensci set of packages, I'll keep the color scheme on black and close this issue.