ropensci / wateRinfo

R package to download time series data from waterinfo.be
https://docs.ropensci.org/wateRinfo
MIT License
14 stars 3 forks source link

Ropensci #47

Closed stijnvanhoey closed 5 years ago

stijnvanhoey commented 5 years ago

Updates as part of the ropensci onboarding procedure, see https://github.com/ropensci/software-review/issues/255#issuecomment-445070486

peterdesmet commented 5 years ago

Looks good to me.

peterdesmet commented 5 years ago

@stijnvanhoey what pkgdown version did you use? I noticed that e.g. the favicon is not displayed and I get a slightly version. Can I commit my build and could you update your version of the package to 1.3.1?

stijnvanhoey commented 5 years ago

yes, update the version, no problem