ropensci / wateRinfo

R package to download time series data from waterinfo.be
https://docs.ropensci.org/wateRinfo
MIT License
13 stars 3 forks source link

CONTRIBUTING now part of side menu on pkgdown website #67

Closed peterdesmet closed 5 years ago

peterdesmet commented 5 years ago

The new website uses pkgdown 1.3.0.9100, which automatically includes CONTRIBUTING and CODE OF CONDUCT in the side menu:

Screenshot 2019-07-30 at 21 49 07

That means we don't have to explicitly link to it CONTRIBUTING in the navbar:

https://github.com/ropensci/wateRinfo/blob/3918e6b4d34a25739b5914edbd1b73adc0c53564/_pkgdown.yml#L33-L34

We don't have to define a navbar at all (but use the default) if we are fine with:

See https://inbo.github.io/inborutils/ for an example

@stijnvanhoey, your call. πŸ˜„

stijnvanhoey commented 5 years ago

I'm always been keen on the custom navbar and using tutorials instead of articles, you know ;-). But, in sake of uniformity/consistency and simplicity (less customization) , I'm fine with the changes and having the default navbar...

peterdesmet commented 5 years ago

☺️ Yay! Before I do that, I noticed something odd with the titles of the articles. I created a separate issue for this: #68

peterdesmet commented 5 years ago

Note that changelog is also included (https://ropensci.github.io/wateRinfo/news/index.html) by using the default navbar.