ropensci / wateRinfo

R package to download time series data from waterinfo.be
https://docs.ropensci.org/wateRinfo
MIT License
13 stars 3 forks source link

https://docs.ropensci.org/wateRinfo #76

Closed peterdesmet closed 4 years ago

peterdesmet commented 4 years ago

The website referenced at the top of the repo is now https://docs.ropensci.org/wateRinfo. Has this recently changed from https://ropensci.github.io/wateRinfo?

Which one is hosted from where? I don't think it makes sense to maintain (the CI for) both.

peterdesmet commented 4 years ago

Note that for rgbif https://ropensci.github.io/rgbif/ redirects to https://docs.ropensci.org/rgbif/

stijnvanhoey commented 4 years ago

Good point, when building the https://docs.ropensci.org/wateRinfo website is managed by ropensci for all packages a-like, I do not think the https://ropensci.github.io/wateRinfo website is still required? Should we get rid of the entire Travis setup?

peterdesmet commented 4 years ago

Well, the Travis setup is also running tests, is that done by docs.ropensci setup as well? Ping @sckott or anyone else at rOpenSci. If not the travis setup should probably stay, but without the pkgdown build.

sckott commented 4 years ago

You don't have to use the docs.ropensci site - you can use the other one. Up to you. So Jeroen manages a system that builds the docs - it does have to build the pkg to make the docs https://dev.ropensci.org/job/wateRinfo/ but it's not like travis in terms of running tests, and no badges -

note 1: docs.ropensci does get built on every commit - i think at some point they'll be option to configure to have the page at specific versions like readthedocs does, but not sure

note 2: if you go with the docs.ropensci site, the pkgdown config file is still used by the docs server

stijnvanhoey commented 4 years ago

@ropensci/jeroen probably you did the adjustment to https://docs.ropensci.org/wateRinfo (or I do not remember anymore doing it ;-))? I agree with @peterdesmet that having both is unclear for the user and does not make sense.

Is the idea to have all CI managed centrally by ropensci (with feedback on PRs,...) or only building the documentation pages?

jeroen commented 4 years ago

Right now we build documentation for all our packages on docs.ropensci.org. We plan to add more free services later, such as a cran-like repository for our packages with binary packages for win/mac.

We will not have all CI managed locally, because packages might want or need very different things from the CI. So you can always use CI services to do checking and testing and other things. But you no longer need to build and puplish docs on via travis :)

jeroen commented 4 years ago

By the way if you turn off gh-pages in this repo, https://ropensci.github.io/wateRinfo will automatically start redirecting to `https://docs.ropensci.org/wateRinfo.

stijnvanhoey commented 4 years ago

Thanks for the update. I'll keep Travis for testing and building the documentation, but no longer publish the docs. The redirection is nice, I'll remove the gh-pages right away.

jeroen commented 4 years ago

OK, be careful that your travis docs bot does not automatically turn on gh-pages again.