search

ropensci / weathercan

R package for downloading weather data from Environment and Climate Change Canada
https://docs.ropensci.org/weathercan
GNU General Public License v3.0
102 stars 29 forks source link

`vcr::vcr_test_path` issue from vcr v1.0.0 #122

Closed sckott closed 1 year ago

sckott commented 3 years ago

With the latest version of vcr just up to CRAN I unfortunately caused breaking changes for some packages depending on vcr. The function vcr_test_path is the issue. The change to that function worked for some, but it apparently has broken other packages.

We have a proposed fix at https://github.com/ropensci/vcr/pull/236 Can you install that fork remotes::install_github("dpprdan/vcr@fix/test_path") and see if that fixes the problem?

steffilazerte commented 3 years ago

Okay, I tested with Fedora through R Hub and was able to replicate the original issue. Then I installed dpprdan/vcr@fix/test_path and added that to my remotes and tried again. The issue is gone! I've tested this fix with:

I had prep errors for Debian GCC on patched and release so couldn't test those

sckott commented 3 years ago

Great, thanks for testing that out. I'll ping here again when i've submitted a new version to CRAN

sckott commented 3 years ago

A new version of vcr is on CRAN https://cloud.r-project.org/web/packages/vcr/ - CRAN checks for your package should be fixed soon once they are using the new version of vcr.

steffilazerte commented 3 years ago

Thanks!

sckott commented 1 year ago

vcr working now for you?

steffilazerte commented 1 year ago

Well enough 😁 most of my tests still use it to a certain degree, but I am afraid to touch sometimes 😅

sckott commented 1 year ago

I am afraid to touch sometimes

b/c of vcr or something else? if vcr, anything I can change in vcr to help with that?

steffilazerte commented 1 year ago

I think it's good now. I think my biggest problem was figuring out how vcr worked when running tests interactively. Either it's improved (🙏🏼) or I got better at understanding! I'll let you know if I run into problems which are vcr related. Thanks for checking in!

sckott commented 1 year ago

yeah the interactive user experience is not ideal for sure. thanks for the feedback