search

ropensci / weathercan

R package for downloading weather data from Environment and Climate Change Canada
https://docs.ropensci.org/weathercan
GNU General Public License v3.0
102 stars 29 forks source link

Create a dir recursively & make compatible with readr 2.0 #124

Closed boshek closed 3 years ago

boshek commented 3 years ago

If the weather app directory didn't exist already, additional levels below weren't being created.

boshek commented 3 years ago

A bit of duct tape required to process the normals data correctly. The new version of readr (just out) has some different defaults. We can revert using this function: https://readr.tidyverse.org/reference/with_edition.html

steffilazerte commented 3 years ago

A couple of weird things with the stations update I'll fix and push here.

boshek commented 3 years ago

@steffilazerte I think this is ready to merge if you have any time for a review.

steffilazerte commented 3 years ago

Thanks I'll take a look soon!

steffilazerte commented 3 years ago

Looks good! Thanks @boshek! To be clear, this was just fixing some problems I introduced with the new stations() function and the cache? I like the idea of pre-building the vignettes too. If you have time, please implement! But also feel free to direct me to a reference and I can make that happen too 😁 🙏🏼 Thank you!