Closed maelle closed 1 year ago
I don't think what the log shows in the error (it's the deprecation warning). I can't explore right now.
I know what this is, I'm surprised I haven't noticed before, thanks for pointing it out!
locally I was able to build the website!
I know what this is, I'm surprised I haven't noticed before, thanks for pointing it out!
So what is it, actually? I'm surprised it worked locally but not on GHA.
@steffilazerte Friendly reminder :smile_cat:
Argh, I thought I knew and thought it was fixed because the dev site has no problems (even if it's ugly :wink: https://ropensci.github.io/weathercan), but nope.
I think it's related to the leaflet map. Are there other packages with leaflet maps in the articles that do work on R-Universe builds?
Side-note, on https://ropensci.github.io/weathercan/articles/mapping.html the CSS rules you add (I guess?) make the logo too big.
@steffilazerte what if you try with the dev version of dependencies? Is the code building the website dependent on an environmental variable called CI (it is TRUE on GitHub Actions but it is unset on R-universe). Thanks @jeroen for the ideas
I'll take a look, thanks
to use dev versions Jeroen suggested to run update.packages(repos = 'https://ropensci.r-universe.dev', ask = FALSE)
Tried these options and it still works locally. Fixed by avoidance 😅 . Move the mapping article to my website and removed from the docs (it wasn't really a weathercan specific tutorial).
We'll see if that works on R-Universe now!
Yes, all green on https://ropensci.r-universe.dev/builds :tada:
That's a pretty smart fix. :grin:
Finally 😅
https://github.com/r-universe/ropensci/actions/runs/4386295506/jobs/7680161044