ropensci / weathercan

R package for downloading weather data from Environment and Climate Change Canada
https://docs.ropensci.org/weathercan
GNU General Public License v3.0
102 stars 29 forks source link

pkgdown error on docs server #135

Closed maelle closed 1 year ago

maelle commented 1 year ago

https://github.com/r-universe/ropensci/actions/runs/4386295506/jobs/7680161044

maelle commented 1 year ago

I don't think what the log shows in the error (it's the deprecation warning). I can't explore right now.

steffilazerte commented 1 year ago

I know what this is, I'm surprised I haven't noticed before, thanks for pointing it out!

maelle commented 1 year ago

locally I was able to build the website!

maelle commented 1 year ago

I know what this is, I'm surprised I haven't noticed before, thanks for pointing it out!

So what is it, actually? I'm surprised it worked locally but not on GHA.

maelle commented 1 year ago

@steffilazerte Friendly reminder :smile_cat:

steffilazerte commented 1 year ago

Argh, I thought I knew and thought it was fixed because the dev site has no problems (even if it's ugly :wink: https://ropensci.github.io/weathercan), but nope.

I think it's related to the leaflet map. Are there other packages with leaflet maps in the articles that do work on R-Universe builds?

maelle commented 1 year ago

Side-note, on https://ropensci.github.io/weathercan/articles/mapping.html the CSS rules you add (I guess?) make the logo too big.

maelle commented 1 year ago

@steffilazerte what if you try with the dev version of dependencies? Is the code building the website dependent on an environmental variable called CI (it is TRUE on GitHub Actions but it is unset on R-universe). Thanks @jeroen for the ideas

steffilazerte commented 1 year ago

I'll take a look, thanks

maelle commented 1 year ago

to use dev versions Jeroen suggested to run update.packages(repos = 'https://ropensci.r-universe.dev', ask = FALSE)

steffilazerte commented 1 year ago

Tried these options and it still works locally. Fixed by avoidance 😅 . Move the mapping article to my website and removed from the docs (it wasn't really a weathercan specific tutorial).

We'll see if that works on R-Universe now!

maelle commented 1 year ago

Yes, all green on https://ropensci.r-universe.dev/builds :tada:

That's a pretty smart fix. :grin:

steffilazerte commented 1 year ago

Finally 😅