search

ropensci / weathercan

R package for downloading weather data from Environment and Climate Change Canada
https://docs.ropensci.org/weathercan
GNU General Public License v3.0
102 stars 29 forks source link

where in the package is the stations object still used #139

Closed maelle closed 1 year ago

maelle commented 1 year ago

The rOpenSci docs build gets

The internal `stations` data has been deprecated in favour of the function `stations()`.
See ?stations for more details.
maelle commented 1 year ago

oh wait it's a startup message, I hadn't noticed that.

maelle commented 1 year ago

what about https://ropensci.org/blog/2023/04/21/ropensci-news-digest-april-2023/#deprecated-data-in-a-package-with-delayedassign

steffilazerte commented 1 year ago

Well the problem is that it's been replaced with a function stations()... so if you call stations you get the function code...

But that change is two years old now, so it's probably not an issue to remove the startup message.

maelle commented 1 year ago

Removing old stuff you assume is not used, and seeing what happens, is a strategy mentioned in https://www.goodreads.com/book/show/54716655-kill-it-with-fire :grin:

steffilazerte commented 1 year ago

Removed in v0.7.1 (e6015a0949dd548258b2d42168cbdd706bafdb07)