ropensci / weathercan

R package for downloading weather data from Environment and Climate Change Canada
https://docs.ropensci.org/weathercan
GNU General Public License v3.0
102 stars 29 forks source link

Abnormal termination #142

Closed busmansholiday closed 3 weeks ago

busmansholiday commented 3 weeks ago

Expected Behavior

Function call should end without an error

Current Behavior

Function call ends with:

test_weather <-weather_dl( + station_ids = unique(station_subset$station_id)[1:3], + time_disp = "UTC", + start = "2020-01-01", + end = "2024-08-15", + interval="day", + format='FALSE', + verbose='TRUE' + ) Getting station: 50308 Adding header data: 50308 Getting station: 54238 Adding header data: 54238 Getting station: 52978 Adding header data: 52978 Error in format && nrow(w) > 0 : invalid 'x' type in 'x && y'

 

| >

Steps to Reproduce (for bugs)

  1. See fragment above

Possible Solution

Context

Your Environment

Successfully installed 31 packages in 6.2 seconds.

devtools::session_info()

  • Session info ------------------------------- setting value version R version 4.2.2 (2022-10-31 ucrt) os Windows Server x64 (build 17763) system x86_64, mingw32 ui RStudio language (EN) collate English_Canada.1252 ctype English_Canada.1252 tz America/Los_Angeles date 2024-08-27 rstudio 2024.04.2+764 Chocolate Cosmos (desktop) pandoc 2.18 @ C:\PROGRA~3\CHOCOL~1\bin\pandoc.exe

busmansholiday commented 3 weeks ago

NOTE: YeGop0218 has no followers and no contributions to any repo. I recommend against following this posting without some legitimation.

busmansholiday commented 3 weeks ago

User error. verbose is a TRUE FALSE/ not a string. Remove quote marks around TRUE and FALSE values.

steffilazerte commented 3 weeks ago

Good catch @busmansholiday, I'll make a note to catch invalid verbose arguments. Glad it worked out for you.