ropensci / weathercan

R package for downloading weather data from Environment and Climate Change Canada
https://docs.ropensci.org/weathercan
GNU General Public License v3.0
102 stars 29 forks source link

Time merge changes on to the master? #24

Closed boshek closed 7 years ago

boshek commented 7 years ago

Do you have any sense if there are any users? I'd hate to break anything for anyone. But at the same time, it would be nice to have all the changes on to the main branch before we get too many commits ahead. Already we are going to have to navigate some merge conflicts. I think I managed to fix what was ailing our appveyor check using this fix: hadley/testthat#144

However, this of course broke the TRAVIS check. It is giving this weird error which I just feel like is a problem with weathercan:

2.16s$ wget http://mirror.ctan.org/systems/mac/mactex/BasicTeX.pkg -O "/tmp/BasicTeX.pkg"
--2017-06-16 03:51:57--  http://mirror.ctan.org/systems/mac/mactex/BasicTeX.pkg
Resolving mirror.ctan.org... 176.28.54.184, 2a01:488:67:1000:b01c:36b8::1
Connecting to mirror.ctan.org|176.28.54.184|:80... connected.
HTTP request sent, awaiting response... 302 Found
Location: http://mirror.unl.edu/ctan/systems/mac/mactex/BasicTeX.pkg [following]
--2017-06-16 03:51:59--  http://mirror.unl.edu/ctan/systems/mac/mactex/BasicTeX.pkg
Resolving mirror.unl.edu... 129.93.2.13
Connecting to mirror.unl.edu|129.93.2.13|:80... connected.
HTTP request sent, awaiting response... 403 Forbidden
2017-06-16 03:51:59 ERROR 403: Forbidden.
The command "wget http://mirror.ctan.org/systems/mac/mactex/BasicTeX.pkg -O "/tmp/BasicTeX.pkg"" failed and exited with 8 during .
Your build has been stopped.
/Users/travis/.travis/job_stages: line 152: shell_session_update: command not found

Whatever the case, what do you think about merging to the master? No worries if you have different ideas.

boshek commented 7 years ago

Check that - minor merge conflict.

steffilazerte commented 7 years ago

Let's do it, I don't think there are many users