search

ropensci / weathercan

R package for downloading weather data from Environment and Climate Change Canada
https://docs.ropensci.org/weathercan
GNU General Public License v3.0
102 stars 29 forks source link

dplyr exports all the required tibble functions so we can remove the tibble dependency. #55

Closed boshek closed 6 years ago

boshek commented 6 years ago

For instance this:

https://github.com/ropensci/weathercan/blob/3b8d291c25f68cb687f6fca34643b16d9c2724be/R/interpolate.R#L72-L74

Can be changed to this:

  ## Convert to tibbles for consistency
  data <- dplyr::as_tibble(data)
  weather <- dplyr::as_tibble(weather)

FWIW I realize that it was me who did this in the first place 🤦‍♂️

steffilazerte commented 6 years ago

Good point, we have tibbles throughout weather.R and interpolate.R too

boshek commented 6 years ago

Push to dev-steffi? Or do you want to review a pull request?

steffilazerte commented 6 years ago

No that's fine, go ahead and push to the dev branch