search

ropensci / weathercan

R package for downloading weather data from Environment and Climate Change Canada
https://docs.ropensci.org/weathercan
GNU General Public License v3.0
102 stars 29 forks source link

Fix issues with ECCC changes #56

Closed steffilazerte closed 6 years ago

steffilazerte commented 6 years ago

Description

ECCC updated information contained in data files. These changes address bugs created and make the package more robust to future changes. Tests included will also alert to future changes.

Related Issue

Best Practices

The following have been updated or added as needed:

codecov-io commented 6 years ago

Codecov Report

Merging #56 into master will decrease coverage by 0.71%. The diff coverage is 94.64%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
- Coverage   90.84%   90.12%   -0.72%     
==========================================
  Files           5        5              
  Lines         535      547      +12     
==========================================
+ Hits          486      493       +7     
- Misses         49       54       +5
Impacted Files Coverage Δ
R/weathercan-pkg.R 0% <0%> (ø) :arrow_up:
R/weather.R 94.88% <96.36%> (-0.51%) :arrow_down:
R/stations.R 92.92% <0%> (-1.77%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9d8df84...70a4eab. Read the comment docs.