search

ropensci / weathercan

R package for downloading weather data from Environment and Climate Change Canada
https://docs.ropensci.org/weathercan
GNU General Public License v3.0
102 stars 29 forks source link

directly reference internal data. Closes #70 #71

Closed boshek closed 5 years ago

boshek commented 5 years ago

Description

Looks like the internal data wasn't explicitly being reference so any floating objects of the same name got passed into the function. I'm not totally clear on how but directly referencing the stations dataframe will avoid this.

Related Issue

Closes #70

codecov-io commented 5 years ago

Codecov Report

Merging #71 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff          @@
##           master   #71   +/-   ##
====================================
  Coverage      77%   77%           
====================================
  Files           5     5           
  Lines         574   574           
====================================
  Hits          442   442           
  Misses        132   132
Impacted Files Coverage Δ
R/weather.R 95.07% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b3eaece...eca7413. Read the comment docs.

boshek commented 5 years ago

Right that makes sense and explains the vagrant stations object.