search

ropensci / weathercan

R package for downloading weather data from Environment and Climate Change Canada
https://docs.ropensci.org/weathercan
GNU General Public License v3.0
102 stars 29 forks source link

Can not download with weather_dl #84

Closed WatershedFlow closed 4 years ago

WatershedFlow commented 4 years ago

I try to download daily data with following code:

Regina<- weather_dl(station_ids = 28011, start = "2019-02-01", interval = "day", quiet = TRUE)

then I got this error without anything else happened, i.e., no data downloaded. Error in 1:grep("Date/Time", preamble$V1) : argument of length 0

Thanks for your help.

steffilazerte commented 4 years ago

Yes, unfortunately this is because of issue #83, ECCC changed the format of their downloads yesterday. I have a fix in the works, and it should be ready for testing soon. Thanks!

steffilazerte commented 4 years ago

@WatershedFlow , if you get the chance to test it, the fix has been posted to the master branch:

install.packages("remotes")
remotes::install_github("ropensci/weathercan")

Then test as you would normally:

library(weathercan)
kam <- weather_dl(station_ids = 51423, start = "2016-01-01", end = "2016-02-15")
kam
steffilazerte commented 4 years ago

We're on CRAN now, you can update with install.packages("weathercan"). Good luck!

WatershedFlow commented 4 years ago

Thanks Steffi,

It works now. This reminds me that ECCC should have some kind of systems to inform you and others who are depending on ECCC's website and data; or even ask them to update tools as weathercan.

I appreciate you so much let me know your quick fix.

Kangsheng

On Sun, Sep 29, 2019 at 11:44 AM Steffi LaZerte notifications@github.com wrote:

We're on CRAN now, you can update with install.packages("weathercan"). Good luck!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ropensci/weathercan/issues/84?email_source=notifications&email_token=ANAH2JKPI6M3JCXO6VJPTDLQMDSPJA5CNFSM4I3HLXD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD732P7A#issuecomment-536324092, or mute the thread https://github.com/notifications/unsubscribe-auth/ANAH2JOJJYWHQP6DU3J7TRDQMDSPJANCNFSM4I3HLXDQ .