search

ropensci / webchem

Chemical Information from the Web
https://docs.ropensci.org/webchem
Other
160 stars 40 forks source link

improve reliability of `with_cts()` #387

Closed Aariq closed 1 year ago

Aariq commented 1 year ago

with_cts() sporadically causes our tests run on GitHub actions to fail. It's likely due to poor performance of CTS, but maybe there's something we can do on our end to make with_cts() more reliable, like adding a retry function to cts_convert() (we even left a TODO comment about this)

https://github.com/ropensci/webchem/blob/64a83e401592ec52f71fd209c5f022b172192688/R/integration.R#L43-L44

Aariq commented 1 year ago

cts_convert() already uses RETRY internally. Maybe we need to increase times beyond the default 3?

Aariq commented 1 year ago

Nevermind, with_cts() tests are failing when no translation is needed—i.e. it skips cts_convert(). So the failing test is more likely related to flavornet (??)