Closed ethanbass closed 1 year ago
Thanks @ethanbass! Wondering if you folks want this to be part of the next release? I need to resubmit v1.3.0 to CRAN with some comments so I can wait until we merge this PR.
Thanks @ethanbass! Wondering if you folks want this to be part of the next release? I need to resubmit v1.3.0 to CRAN with some comments so I can wait until we merge this PR.
Whatever you all want to do in this regard is fine with me. I'm not really familiar with your release schedule
Do we want to add additional tests associated with this PR?
Not sure why checks on ubuntu-20.04 (devel) passed before and do not pass now, maybe we should update GitHub actions? A possible lead here: https://community.rstudio.com/t/github-action-failure-with-rcmd-check-on-ubuntu-devel/129727. I'm going to merge this PR and fix the check afterwards.
as.cas
in bcpc, cts, etox, flavornet, pan, pubchem, srs functions.verbose
argument toas.cas
.as.cas
so it returns a named character vector whose names are the character strings from the original query.as.cas
(since it now retains the names of the original query).lapply
output because I ran into a problem with the way the output was being formatted for "non-cas" cas numbers like "balloon".PR task list:
devtools::document()