ropensci / webchem

Chemical Information from the Web
https://docs.ropensci.org/webchem
Other
160 stars 40 forks source link

Reformat cas #398

Closed ethanbass closed 1 year ago

ethanbass commented 1 year ago

PR task list:

stitam commented 1 year ago

Thanks @ethanbass! Wondering if you folks want this to be part of the next release? I need to resubmit v1.3.0 to CRAN with some comments so I can wait until we merge this PR.

ethanbass commented 1 year ago

Thanks @ethanbass! Wondering if you folks want this to be part of the next release? I need to resubmit v1.3.0 to CRAN with some comments so I can wait until we merge this PR.

Whatever you all want to do in this regard is fine with me. I'm not really familiar with your release schedule

ethanbass commented 1 year ago

Do we want to add additional tests associated with this PR?

stitam commented 1 year ago

Not sure why checks on ubuntu-20.04 (devel) passed before and do not pass now, maybe we should update GitHub actions? A possible lead here: https://community.rstudio.com/t/github-action-failure-with-rcmd-check-on-ubuntu-devel/129727. I'm going to merge this PR and fix the check afterwards.