search

ropensci / writexl

Portable, light-weight data frame to xlsx exporter for R
https://docs.ropensci.org/writexl
Other
210 stars 17 forks source link

Adding some formatting options #67

Open rix133 opened 1 year ago

rix133 commented 1 year ago

I tried to address simple issues from #4 the first commit is only simple stuff but I forgot to change the parameter count {"C_write_data_frame_list", (DL_FUNC) &C_write_data_frame_list, 5}, I totally understand If this would be rejected as you stated that this might make the code harder to maintain.

jeroen commented 1 year ago

Hey, thanks for your contribution. Are you aware of the new openxlsx2 package by @janmarvin? It seems to have a lot of formatting functionality built-in: https://janmarvin.r-universe.dev/openxlsx2/doc/manual.html

The vignettes are also very extensive: https://janmarvin.r-universe.dev/openxlsx2

In what way would we benefit from duplicating this functionality in writexl?

rix133 commented 1 year ago

It's totally up to you. :) I just prefer to use writexl as it is fast and works well. I just wanted those convenience options to the result. I can't install openxlsx2 from Bioconductor or CRAN so I have not been testing openxlsx2 (not available for 4.3.1 on windows) but I can see that this has a lot of functionality. I like the simplicity to just write writexl::write_xlsx(df, "./results/output.xlsx") when I have to share something with people not using R and almost always they have to freeze top row, adjust column widths to see the column names and and set autofilter when they explore the result. As I undesrtand from https://github.com/ropensci/writexl/issues/4 I'm not alone.

jmcnamara commented 1 year ago

In what way would we benefit from duplicating this functionality in writexl?

If we had done it first in writexl we wouldn't be duplicating. A lot of the formatting functionality was already available in libxlsxwriter.

rix133 commented 1 year ago

In what way would we benefit from duplicating this functionality in writexl?

If we had done it first in writexl we wouldn't be duplicating. A lot of the formatting functionality was already available in libxlsxwriter.

exactly, I only used the options that the current bundled version of libxlsxwriter provides