search

ropensci / writexl

Portable, light-weight data frame to xlsx exporter for R
https://docs.ropensci.org/writexl
Other
209 stars 17 forks source link

Support NetBSD, thanks #73

Closed makoto-fujiwara closed 9 months ago

makoto-fujiwara commented 9 months ago

--- src/minizip/ioapi.h.orig 2023-01-07 02:19:12.000000000 +0900 +++ src/minizip/ioapi.h 2024-02-06 21:15:18.108719602 +0900 @@ -56,7 +56,7 @@

define ftello64 ftell

define fseeko64 fseek

else

-#if defined(FreeBSD) || defined(OpenBSD) +#if defined(FreeBSD) || defined(OpenBSD) || defined(NetBSD)

define fopen64 fopen

define ftello64 ftello

define fseeko64 fseeko

jeroen commented 9 months ago

Can you send a PR?

jmcnamara commented 9 months ago

This is already fixed/available upstream:

https://github.com/jmcnamara/libxlsxwriter/blob/main/third_party/minizip/ioapi.h#L59 https://github.com/jmcnamara/libxlsxwriter/blob/main/include/xlsxwriter/third_party/ioapi.h#L59

jeroen commented 9 months ago

OK I have imported the latest libxlsxwriter code, so that should fix it then.