search

ropensci / xslt

Extension of xml2 package for xsl transformations
https://docs.ropensci.org/xslt
27 stars 1 forks source link

Import Rcpp #8

Closed jimhester closed 4 years ago

jimhester commented 4 years ago

xml2 1.3.0 no longer uses Rcpp, so we need to import Rcpp in xslt to ensure it is loaded when the functions are called. Otherwise you get the following error from the examples

Error in doc_xslt_apply(doc$doc, stylesheet$doc, paramstr) :
  function 'enterRNGScope' not provided by package 'Rcpp'
Calls: xml_xslt -> xml_xslt.xml_document -> doc_xslt_apply
jeroen commented 4 years ago

Thanks. So the XPtrDoc that we include from xml2_types.h will keep working? We probably need to force a rebuild of xslt binary packages when you release the new xml2?

jimhester commented 4 years ago

Yeah, the external interface for those types stayed the same, but you are probably right that it is safest to rebuild the xslt binaries.

jeroen commented 4 years ago

Can you give me a heads-up when you release to CRAN? Then I'll release a new xslt the day after.

jimhester commented 4 years ago

I am submitting today, will let you know when it goes through.

jeroen commented 4 years ago

FWIW I think this should be a major version bump, given the ABI break.