search

ropenscilabs / statistical-software-review

Experiments for rOpenSci's project for peer review of statistical software
1 stars 0 forks source link

Template test (#3) #24

Open mpadge opened 3 years ago

mpadge commented 3 years ago

Submitting Author: Name (@github_handle) Other Package Authors: (delete if none) Name (@github_handle) Repository: https://github.com/hypertidy/geodist Version submitted: Submission type: Standard Editor: me Reviewers: them

Archive: TBD Version accepted: TBD

ropensci-review-bot commented 3 years ago

Thanks for submitting to rOpenSci, our editors and @ropensci-review-bot will reply soon. Type @ropensci-review-bot help for help.

ropensci-review-bot commented 3 years ago

Error (500). The editorcheck service is currently unavailable

mpadge commented 3 years ago

@ropensci-review-bot check package

ropensci-review-bot commented 3 years ago

Thanks, about to send the query.

ropensci-review-bot commented 3 years ago

:rocket:

Editor check started

:wave:

ropensci-review-bot commented 3 years ago

Checks for geodist (v0.0.7.012)

git hash: 988118a5

Important: All failing checks above must be addressed prior to proceeding

Package License: MIT + file LICENSE

1. Statistical Properties

This package features some noteworthy statistical properties which may need to be clarified by a handling editor prior to progressing.

Details of statistical properties (click to open)

The package has: - code in C (87% in 14 files), C/C++ Header (3% in 3 files) and R (10% in 5 files) - 2 authors - 1 vignette - no internal data file - 1 imported package - 3 exported functions (median 27 lines of code) - 42 non-exported functions in R (median 12 lines of code) - 94 C/C++ functions (median 27 lines of code) --- Statistical properties of package structure as distributional percentiles in relation to all current CRAN packages The following terminology is used: - `loc` = "Lines of Code" - `fn` = "function" - `exp`/`not_exp` = exported / not exported The final measure (`fn_call_network_size`) is the total number of calls between functions (in R), or more abstract relationships between code objects in other languages. Values are flagged as "noteworthy" when they lie in the upper or lower 5th percentile. |measure | value| percentile|noteworthy | |:------------------------|-----:|----------:|:----------| |files_R | 5| 29.8| | |files_src | 17| 95.7| | |files_vignettes | 1| 64.8| | |files_tests | 5| 78.5| | |loc_R | 319| 30.2| | |loc_src | 2783| 80.3| | |loc_vignettes | 182| 67.7| | |loc_tests | 416| 68.4| | |num_vignettes | 1| 60.7| | |n_fns_r | 45| 44.8| | |n_fns_r_exported | 3| 10.4| | |n_fns_r_not_exported | 42| 53.5| | |n_fns_src | 94| 94.8| | |n_fns_per_file_r | 6| 68.2| | |n_fns_per_file_src | 7| 57.3| | |num_params_per_fn | 4| 54.3| | |loc_per_fn_r | 13| 52.9| | |loc_per_fn_r_exp | 27| 60.6| | |loc_per_fn_r_not_exp | 12| 55.9| | |loc_per_fn_src | 27| 84.4| | |rel_whitespace_R | 30| 48.8| | |rel_whitespace_src | 16| 94.9| | |rel_whitespace_vignettes | 12| 69.6| | |rel_whitespace_tests | 14| 83.0| | |doclines_per_fn_exp | 38| 46.5| | |doclines_per_fn_not_exp | 0| 0.0|TRUE | |fn_call_network_size | 215| 88.2| | ---

1a. Network visualisation

Interactive network visualisation of calls between objects in package can be viewed by clicking here

2. goodpractice and other checks

Details of goodpractice and other checks (click to open)

### 3a. Continuous Integration Badges [![github](https://github.com/hypertidy/geodist/workflows/R-CMD-check/badge.svg)](https://github.com/hypertidy/geodist/actions) **GitHub Workflow Results** |name |conclusion |sha |date | |:-------------|:----------|:------|:----------| |pkgdown |success |f45a85 |2021-02-11 | |R-CMD-check |success |f45a85 |2021-02-11 | |test-coverage |success |f45a85 |2021-02-11 | --- ### 3b. `goodpractice` results ### `R CMD check` with [rcmdcheck](https://r-lib.github.io/rcmdcheck/) rcmdcheck found no errors, warnings, or notes ### Test coverage with [covr](https://covr.r-lib.org/) Package coverage: 89.76 ### Cyclocomplexity with [cyclocomp](https://github.com/MangoTheCat/cyclocomp) No functions have cyclocomplexity >= 15 ### Static code analyses with [lintr](https://github.com/jimhester/lintr) [lintr](https://github.com/jimhester/lintr) found no issues with this package!

Package Versions

|package |version | |:--------|:---------| |pkgstats |0.0.2.1 | |pkgcheck |0.0.1.493 |

Editor-in-Chief Instructions:

Processing may not proceed until the items marked with :heavy_multiplication_x: have been resolved.

mpadge commented 3 years ago

@ropensci-review-bot check package

ropensci-review-bot commented 3 years ago

Thanks, about to send the query.

ropensci-review-bot commented 3 years ago

:rocket:

The following problems were found in your submission template:

:wave:

ropensci-review-bot commented 3 years ago

Checks for geodist (v0.0.7.012)

git hash: 988118a5

Important: All failing checks above must be addressed prior to proceeding

Package License: MIT + file LICENSE

1. Statistical Properties

This package features some noteworthy statistical properties which may need to be clarified by a handling editor prior to progressing.

Details of statistical properties (click to open)

The package has: - code in C (87% in 14 files), C/C++ Header (3% in 3 files) and R (10% in 5 files) - 2 authors - 1 vignette - no internal data file - 1 imported package - 3 exported functions (median 27 lines of code) - 42 non-exported functions in R (median 12 lines of code) - 94 C/C++ functions (median 27 lines of code) --- Statistical properties of package structure as distributional percentiles in relation to all current CRAN packages The following terminology is used: - `loc` = "Lines of Code" - `fn` = "function" - `exp`/`not_exp` = exported / not exported The final measure (`fn_call_network_size`) is the total number of calls between functions (in R), or more abstract relationships between code objects in other languages. Values are flagged as "noteworthy" when they lie in the upper or lower 5th percentile. |measure | value| percentile|noteworthy | |:------------------------|-----:|----------:|:----------| |files_R | 5| 29.8| | |files_src | 17| 95.7| | |files_vignettes | 1| 64.8| | |files_tests | 5| 78.5| | |loc_R | 319| 30.2| | |loc_src | 2783| 80.3| | |loc_vignettes | 182| 67.7| | |loc_tests | 416| 68.4| | |num_vignettes | 1| 60.7| | |n_fns_r | 45| 44.8| | |n_fns_r_exported | 3| 10.4| | |n_fns_r_not_exported | 42| 53.5| | |n_fns_src | 94| 94.8| | |n_fns_per_file_r | 6| 68.2| | |n_fns_per_file_src | 7| 57.3| | |num_params_per_fn | 4| 54.3| | |loc_per_fn_r | 13| 52.9| | |loc_per_fn_r_exp | 27| 60.6| | |loc_per_fn_r_not_exp | 12| 55.9| | |loc_per_fn_src | 27| 84.4| | |rel_whitespace_R | 30| 48.8| | |rel_whitespace_src | 16| 94.9| | |rel_whitespace_vignettes | 12| 69.6| | |rel_whitespace_tests | 14| 83.0| | |doclines_per_fn_exp | 38| 46.5| | |doclines_per_fn_not_exp | 0| 0.0|TRUE | |fn_call_network_size | 215| 88.2| | ---

1a. Network visualisation

Interactive network visualisation of calls between objects in package can be viewed by clicking here

2. goodpractice and other checks

Details of goodpractice and other checks (click to open)

### 3a. Continuous Integration Badges [![github](https://github.com/hypertidy/geodist/workflows/R-CMD-check/badge.svg)](https://github.com/hypertidy/geodist/actions) **GitHub Workflow Results** |name |conclusion |sha |date | |:-------------|:----------|:------|:----------| |pkgdown |success |f45a85 |2021-02-11 | |R-CMD-check |success |f45a85 |2021-02-11 | |test-coverage |success |f45a85 |2021-02-11 | --- ### 3b. `goodpractice` results ### `R CMD check` with [rcmdcheck](https://r-lib.github.io/rcmdcheck/) rcmdcheck found no errors, warnings, or notes ### Test coverage with [covr](https://covr.r-lib.org/) Package coverage: 89.76 ### Cyclocomplexity with [cyclocomp](https://github.com/MangoTheCat/cyclocomp) No functions have cyclocomplexity >= 15 ### Static code analyses with [lintr](https://github.com/jimhester/lintr) [lintr](https://github.com/jimhester/lintr) found no issues with this package!

Package Versions

|package |version | |:--------|:---------| |pkgstats |0.0.2.1 | |pkgcheck |0.0.1.493 |

Editor-in-Chief Instructions:

Processing may not proceed until the items marked with :heavy_multiplication_x: have been resolved.

ropensci-review-bot commented 2 years ago

Checks for fwildclusterboot (v0.9.1)

git hash: 4d87fb72

Important: All failing checks above must be addressed prior to proceeding

Package License: GPL-3

1. rOpenSci Statistical Standards (srr package)

This package is in the following category:

:heavy_check_mark: All applicable standards [v0.1.0] have been documented in this package (70 complied with; 46 N/A standards)

Click to see the report of author-reported standards compliance of the package with links to associated lines of code, which can be re-generated locally by running the srr_report() function from within a local clone of the repository.

2. Package Dependencies

Details of Package Dependency Usage (click to open)

The table below tallies all function calls to all packages ('ncalls'), both internal (r-base + recommended, along with the package itself), and external (imported and suggested packages). 'NA' values indicate packages to which no identified calls to R functions could be found. Note that these results are generated by an automated code-tagging system which may not be entirely accurate. |type |package | ncalls| |:----------|:----------------|------:| |internal |base | 447| |internal |fwildclusterboot | 123| |internal |stats | 88| |internal |utils | 9| |internal |graphics | 8| |internal |compiler | 1| |imports |collapse | 14| |imports |dreamerr | 11| |imports |dqrng | 9| |imports |generics | 5| |imports |Matrix | 3| |imports |Matrix.utils | 2| |imports |JuliaConnectoR | 1| |imports |Formula | NA| |imports |Rcpp | NA| |suggests |fabricatr | 11| |suggests |fixest | NA| |suggests |lfe | NA| |suggests |ivreg | NA| |suggests |clubSandwich | NA| |suggests |sandwich | NA| |suggests |lmtest | NA| |suggests |data.table | NA| |suggests |covr | NA| |suggests |knitr | NA| |suggests |rmarkdown | NA| |suggests |broom | NA| |suggests |modelsummary | NA| |suggests |bench | NA| |suggests |testthat | NA| |suggests |tibble | NA| |linking_to |Rcpp | NA| |linking_to |RcppArmadillo | NA| |linking_to |RcppEigen | NA| Click below for tallies of functions used in each package. Locations of each call within this package may be generated locally by running 's <- pkgstats::pkgstats()', and examining the 'external_calls' table.

base

length (48), list (33), call (31), c (24), unique (20), lapply (13), rep (13), as.vector (11), names (11), t (11), sqrt (10), stop (10), drop (9), numeric (9), vapply (9), ifelse (8), mean (8), which (8), as.matrix (7), data.frame (7), match.call (7), paste0 (7), ncol (6), paste (6), replace (6), nrow (5), seq_along (5), abs (4), as.numeric (4), for (4), is.null (4), mode (4), Reduce (4), sample (4), sapply (4), sum (4), tcrossprod (4), vector (4), as.character (3), col (3), colnames (3), environment (3), min (3), q (3), suppressWarnings (3), switch (3), as.integer (2), attr (2), crossprod (2), factor (2), getOption (2), max (2), round (2), solve (2), append (1), as.data.frame (1), as.factor (1), by (1), cbind (1), class (1), do.call (1), exp (1), if (1), is.na (1), is.numeric (1), loadedNamespaces (1), message (1), norm (1), Recall (1), sample.int (1), seq (1), sort (1), Sys.getenv (1), try (1), unlist (1)

fwildclusterboot

check_set_full_enumeration (8), get_ssc_julia (8), set_seed (7), teststat (6), boot_algo_julia (5), get_cluster (5), boot_algo2 (4), crosstab (4), get_ssc (4), gtools_permutations (4), model_matrix (4), cpp_get_nb_threads (3), eigenMapMatMult (3), get_bootstrap_pvalue (3), preprocess2.felm (3), preprocess2.fixest (3), preprocess2.lm (3), demean_fe (2), p_val_null2 (2), p_val_null2_x (2), p_val_null2_x_sign_level (2), preprocess2.ivreg (2), transform_fe (2), boot_algo1 (1), boot_ssc (1), boottest (1), boottest.felm (1), boottest.fixest (1), boottest.ivreg (1), boottest.lm (1), check_boottest_args_plus (1), check_mboottest_args_plus (1), check_params_in_model (1), check_r_lean (1), check_set_nthreads (1), confint.boottest (1), crosstab4 (1), get_seed (1), get_start_vals (1), getBoottest_boot_algo (1), getBoottest_nthreads (1), glance.boottest (1), invert_p_val (1), mboottest (1), mboottest.felm (1), mboottest.fixest (1), mboottest.lm (1), model_matrix.felm (1), model_matrix.fixest (1), model_matrix.lm (1), nobs.boottest (1), nobs.mboottest (1), plot.boottest (1), preprocess2 (1), print.boottest (1), to_integer (1), wildboottestHC (1)

stats

weights (25), model.matrix (13), formula (8), coef (6), model.frame (6), na.omit (6), nobs (4), aggregate (3), model.response (3), na.exclude (3), as.formula (2), reformulate (2), C (1), D (1), na.action (1), na.pass (1), rlnorm (1), uniroot (1), update (1)

collapse

fsum (7), GRP (4), qF (3)

dreamerr

validate_dots (10), check_value (1)

fabricatr

draw_normal_icc (5), draw_binary (4), draw_ordered (1), fabricate (1)

dqrng

dqsample (8), dqrnorm (1)

utils

data (8), combn (1)

graphics

plot (5), abline (3)

generics

tidy (4), glance (1)

Matrix

t (2), Diagonal (1)

Matrix.utils

aggregate.Matrix (2)

compiler

cmpfun (1)

JuliaConnectoR

juliaImport (1)

**NOTE:** Some imported packages appear to have no associated function calls; please ensure with author that these 'Imports' are listed appropriately.

3. Statistical Properties

This package features some noteworthy statistical properties which may need to be clarified by a handling editor prior to progressing.

Details of statistical properties (click to open)

The package has: - code in C++ (7% in 2 files) and R (93% in 38 files) - 2 authors - 3 vignettes - 1 internal data file - 9 imported packages - 43 exported functions (median 9 lines of code) - 106 non-exported functions in R (median 25 lines of code) - 11 R functions (median 11 lines of code) --- Statistical properties of package structure as distributional percentiles in relation to all current CRAN packages The following terminology is used: - `loc` = "Lines of Code" - `fn` = "function" - `exp`/`not_exp` = exported / not exported All parameters are explained as tooltips in the locally-rendered HTML version of this report generated by [the `checks_to_markdown()` function](https://docs.ropensci.org/pkgcheck/reference/checks_to_markdown.html) The final measure (`fn_call_network_size`) is the total number of calls between functions (in R), or more abstract relationships between code objects in other languages. Values are flagged as "noteworthy" when they lie in the upper or lower 5th percentile. |measure | value| percentile|noteworthy | |:------------------------|-----:|----------:|:----------| |files_R | 38| 92.7| | |files_src | 2| 79.1| | |files_vignettes | 3| 92.4| | |files_tests | 15| 94.4| | |loc_R | 3085| 90.9| | |loc_src | 235| 30.4| | |loc_vignettes | 749| 86.3| | |loc_tests | 2278| 94.9| | |num_vignettes | 3| 94.2| | |data_size_total | 14024| 72.7| | |data_size_median | 14024| 81.0| | |n_fns_r | 149| 85.0| | |n_fns_r_exported | 43| 85.4| | |n_fns_r_not_exported | 106| 84.9| | |n_fns_src | 11| 31.7| | |n_fns_per_file_r | 2| 41.3| | |n_fns_per_file_src | 6| 54.3| | |num_params_per_fn | 2| 11.9| | |loc_per_fn_r | 18| 54.7| | |loc_per_fn_r_exp | 9| 19.2| | |loc_per_fn_r_not_exp | 25| 72.0| | |loc_per_fn_src | 11| 28.5| | |rel_whitespace_R | 22| 92.6| | |rel_whitespace_src | 26| 39.9| | |rel_whitespace_vignettes | 43| 92.9| | |rel_whitespace_tests | 21| 94.7| | |doclines_per_fn_exp | 14| 4.8|TRUE | |doclines_per_fn_not_exp | 0| 0.0|TRUE | |fn_call_network_size | 128| 83.0| | ---

3a. Network visualisation

Click to see the interactive network visualisation of calls between objects in package

4. goodpractice and other checks

Details of goodpractice checks (click to open)

#### 3a. Continuous Integration Badges [![R-CMD-check](https://github.com/s3alfisc/fwildclusterboot/workflows/R-CMD-check/badge.svg)](https://github.com/s3alfisc/fwildclusterboot/actions) **GitHub Workflow Results** | id|name |conclusion |sha | run_number|date | |----------:|:--------------------------|:----------|:------|----------:|:----------| | 2479445274|pages build and deployment |success |168280 | 146|2022-06-11 | | 2563811741|pkgcheck |failure |4d87fb | 14|2022-06-26 | | 2479420856|pkgdown |success |71f9a3 | 90|2022-06-11 | | 2563811740|R-CMD-check |success |4d87fb | 436|2022-06-26 | | 2479420857|test-coverage |success |71f9a3 | 423|2022-06-11 | --- #### 3b. `goodpractice` results #### `R CMD check` with [rcmdcheck](https://r-lib.github.io/rcmdcheck/) R CMD check generated the following error: 1. checking tests ... Running ‘testthat.R’ ERROR Running the tests in ‘tests/testthat.R’ failed. Last 13 lines of output: 2. ├─base::suppressWarnings(...) at test-tstat_equivalence.R:560:6 3. │ └─base::withCallingHandlers(...) 4. ├─fwildclusterboot::boottest(...) 5. └─fwildclusterboot:::boottest.ivreg(...) 6. └─fwildclusterboot:::set_seed(...) 7. └─JuliaConnectoR::juliaEval("using StableRNGs") 8. └─JuliaConnectoR:::ensureJuliaConnection() 9. └─JuliaConnectoR:::startJulia() 10. └─JuliaConnectoR:::juliaConnection() 11. └─JuliaConnectoR:::runJuliaServer(multiclient = FALSE) 12. └─JuliaConnectoR:::getJuliaExecutablePath() [ FAIL 11 | WARN 12 | SKIP 0 | PASS 241 ] Error: Test failures Execution halted R CMD check generated the following note: 1. checking installed package size ... NOTE installed size is 6.5Mb sub-directories of 1Mb or more: libs 5.5Mb R CMD check generated the following test_fail: 1. > library(testthat) > library(fwildclusterboot) > > test_check("fwildclusterboot") Loading required package: Matrix The variable 'X2' has been removed because of collinearity (see $collin.var). Attaching package: 'generics' The following object is masked from 'package:fixest': estfun The following objects are masked from 'package:base': as.difftime, as.factor, as.ordered, intersect, is.element, setdiff, setequal, union Starting Julia ... Starting Julia ... Loading required namespace: data.table R Note: The bootstrap usually performs best when the confidence level (here, 0.95 %) times the number of replications plus 1 ( 1024 + 1 = 1025 ) is an integer. Variables 'log_income::17.2069212919256:Q1_immigration::3' and 'log_income::18.0802367820713:Q1_immigration::3' have been removed because of collinearity (see $collin.var). Note: The bootstrap usually performs best when the confidence level (here, 0.95 %) times the number of replications plus 1 ( 17 + 1 = 18 ) is an integer. NOTE: 2 fixed-effect singletons were removed (2 observations). Error in eval(predvars, data, env) : object 'clustid' not found Error in eval(predvars, data, env) : object 'clustid' not found Error in eval(predvars, data, env) : object 'clustid' not found WildBootTests.jl Starting Julia ... Starting Julia ... Starting Julia ... Starting Julia ... Starting Julia ... Variance contained negative values in the diagonal and was 'fixed' (a la Cameron, Gelbach & Miller 2011). Variance contained negative values in the diagonal and was 'fixed' (a la Cameron, Gelbach & Miller 2011). Variance contained negative values in the diagonal and was 'fixed' (a la Cameron, Gelbach & Miller 2011). Variance contained negative values in the diagonal and was 'fixed' (a la Cameron, Gelbach & Miller 2011). boottest() boottest() Starting Julia ... Part 1: Large B Tests start ols/wls type: rademacher p-val: two-tailed null imposed: TRUE rademacher two-tailed TRUE Starting Julia ... Attaching package: 'sandwich' The following object is masked from 'package:generics': estfun Loading required package: zoo Attaching package: 'zoo' The following objects are masked from 'package:base': as.Date, as.Date.numeric Attaching package: 'lmtest' The following object is masked from 'package:lfe': waldtest Starting Julia ... Starting Julia ... Starting Julia ... Error in Q1_immigration + Q2_defense : non-numeric argument to binary operator Error in Q1_immigration + Q2_defense : non-numeric argument to binary operator [ FAIL 11 | WARN 12 | SKIP 0 | PASS 241 ] ══ Warnings ════════════════════════════════════════════════════════════════════ ── Warning (test_multicollinearity.R:18:3): test multicollinearity ───────────── the matrix is either rank-deficient or indefinite Backtrace: 1. lfe::felm(Y ~ X1 + X2, data = data) at test_multicollinearity.R:18:2 2. lfe:::felm.mm(...) 3. lfe:::newols(...) 4. lfe:::cholx(cp) 6. base::chol.default(mat, pivot = TRUE, tol = tol) ── Warning (test_tidy.R:9:3): test tidiers with q = 1 ────────────────────────── There are only 1024 unique draws from the rademacher distribution for 10 bootstrap clusters. Therefore, B = 1024 with full enumeration. Consider using webb weights instead. Further, note that under full enumeration and with B = 1024 bootstrap draws, only 2^(#clusters - 1) = 512 distinct t-statistics and p-values can be computed. For a more thorough discussion, see Webb `Reworking wild bootstrap based inference for clustered errors` (2013). Backtrace: 1. fwildclusterboot::boottest(...) at test_tidy.R:9:2 2. fwildclusterboot:::boottest.lm(...) 3. fwildclusterboot:::check_set_full_enumeration(...) ── Warning (test_tidy.R:15:3): test tidiers with q = 1 ───────────────────────── There are only 1024 unique draws from the rademacher distribution for 10 bootstrap clusters. Therefore, B = 1024 with full enumeration. Consider using webb weights instead. Further, note that under full enumeration and with B = 1024 bootstrap draws, only 2^(#clusters - 1) = 512 distinct t-statistics and p-values can be computed. For a more thorough discussion, see Webb `Reworking wild bootstrap based inference for clustered errors` (2013). Backtrace: 1. fwildclusterboot::boottest(...) at test_tidy.R:15:2 2. fwildclusterboot:::boottest.lm(...) 3. fwildclusterboot:::check_set_full_enumeration(...) ── Warning (test-error_warning.R:595:7): errors and warnings q = 1 ───────────── Currently, boottest() calculates confidence intervals for one-sided hypotheses only for boot_algo = 'WildBootTests.jl'. Backtrace: 1. testthat::expect_error(...) at test-error_warning.R:595:6 8. fwildclusterboot:::boottest.fixest(...) 9. fwildclusterboot:::r_algo_checks(...) ── Warning (test-error_warning.R:596:7): errors and warnings q = 1 ───────────── Currently, boottest() calculates confidence intervals for one-sided hypotheses only for boot_algo = 'WildBootTests.jl'. Backtrace: 1. testthat::expect_error(...) at test-error_warning.R:596:6 8. fwildclusterboot:::boottest.felm(...) 9. fwildclusterboot:::r_algo_checks(...) ── Warning (test-method_equivalence.R:74:3): Do different, but equivalent ways to specify linear models lead to equivalent results? ── Negative eigenvalues set to zero in multiway clustered variance matrix. See felm(...,psdef=FALSE) Backtrace: 1. lfe::felm(...) at test-method_equivalence.R:74:2 2. lfe:::felm.mm(...) 3. lfe:::newols(...) ── Warning (test-method_equivalence.R:86:3): Do different, but equivalent ways to specify linear models lead to equivalent results? ── Negative eigenvalues set to zero in multiway clustered variance matrix. See felm(...,psdef=FALSE) Backtrace: 1. lfe::felm(...) at test-method_equivalence.R:86:2 2. lfe:::felm.mm(...) 3. lfe:::newols(...) ── Warning (test-method_equivalence.R:89:3): Do different, but equivalent ways to specify linear models lead to equivalent results? ── Negative eigenvalues set to zero in multiway clustered variance matrix. See felm(...,psdef=FALSE) Backtrace: 1. lfe::felm(...) at test-method_equivalence.R:89:2 2. lfe:::felm.mm(...) 3. lfe:::newols(...) ── Warning (test-uncategorized.R:27:3): uncategorized tests ──────────────────── There are only 64 unique draws from the rademacher distribution for 6 bootstrap clusters. Therefore, B = 64 with full enumeration. Consider using webb weights instead. Further, note that under full enumeration and with B = 64 bootstrap draws, only 2^(#clusters - 1) = 32 distinct t-statistics and p-values can be computed. For a more thorough discussion, see Webb `Reworking wild bootstrap based inference for clustered errors` (2013). Backtrace: 1. fwildclusterboot::boottest(...) at test-uncategorized.R:27:2 2. fwildclusterboot:::boottest.fixest(...) 3. fwildclusterboot:::check_set_full_enumeration(...) ── Warning (test-uncategorized.R:28:3): uncategorized tests ──────────────────── There are only 64 unique draws from the rademacher distribution for 6 bootstrap clusters. Therefore, B = 64 with full enumeration. Consider using webb weights instead. Further, note that under full enumeration and with B = 64 bootstrap draws, only 2^(#clusters - 1) = 32 distinct t-statistics and p-values can be computed. For a more thorough discussion, see Webb `Reworking wild bootstrap based inference for clustered errors` (2013). Backtrace: 1. fwildclusterboot::boottest(...) at test-uncategorized.R:28:2 2. fwildclusterboot:::boottest.fixest(...) 3. fwildclusterboot:::check_set_full_enumeration(...) ── Warning (test-uncategorized.R:29:3): uncategorized tests ──────────────────── There are only 64 unique draws from the rademacher distribution for 6 bootstrap clusters. Therefore, B = 64 with full enumeration. Consider using webb weights instead. Further, note that under full enumeration and with B = 64 bootstrap draws, only 2^(#clusters - 1) = 32 distinct t-statistics and p-values can be computed. For a more thorough discussion, see Webb `Reworking wild bootstrap based inference for clustered errors` (2013). Backtrace: 1. fwildclusterboot::boottest(...) at test-uncategorized.R:29:2 2. fwildclusterboot:::boottest.fixest(...) 3. fwildclusterboot:::check_set_full_enumeration(...) ── Warning (test-uncategorized.R:30:3): uncategorized tests ──────────────────── There are only 64 unique draws from the rademacher distribution for 6 bootstrap clusters. Therefore, B = 64 with full enumeration. Consider using webb weights instead. Further, note that under full enumeration and with B = 64 bootstrap draws, only 2^(#clusters - 1) = 32 distinct t-statistics and p-values can be computed. For a more thorough discussion, see Webb `Reworking wild bootstrap based inference for clustered errors` (2013). Backtrace: 1. fwildclusterboot::boottest(...) at test-uncategorized.R:30:2 2. fwildclusterboot:::boottest.fixest(...) 3. fwildclusterboot:::check_set_full_enumeration(...) ══ Failed tests ════════════════════════════════════════════════════════════════ ── Error (test_tidy.R:22:3): test tidiers with q = 1 ─────────────────────────── Error in `getJuliaExecutablePath()`: Julia not found in path. Please check your Julia setup. Backtrace: ▆ 1. ├─fwildclusterboot::boottest(...) at test_tidy.R:22:2 2. └─fwildclusterboot:::boottest.lm(...) 3. └─fwildclusterboot:::set_seed(...) 4. └─JuliaConnectoR::juliaEval("using StableRNGs") 5. └─JuliaConnectoR:::ensureJuliaConnection() 6. └─JuliaConnectoR:::startJulia() 7. └─JuliaConnectoR:::juliaConnection() 8. └─JuliaConnectoR:::runJuliaServer(multiclient = FALSE) 9. └─JuliaConnectoR:::getJuliaExecutablePath() ── Error (test_tidy.R:50:3): test tidiers with q > 1 ─────────────────────────── Error in `getJuliaExecutablePath()`: Julia not found in path. Please check your Julia setup. Backtrace: ▆ 1. ├─fwildclusterboot::mboottest(...) at test_tidy.R:50:2 2. └─fwildclusterboot:::mboottest.lm(...) 3. └─fwildclusterboot:::set_seed(...) 4. └─JuliaConnectoR::juliaEval("using StableRNGs") 5. └─JuliaConnectoR:::ensureJuliaConnection() 6. └─JuliaConnectoR:::startJulia() 7. └─JuliaConnectoR:::juliaConnection() 8. └─JuliaConnectoR:::runJuliaServer(multiclient = FALSE) 9. └─JuliaConnectoR:::getJuliaExecutablePath() ── Error (test-error_warning.R:82:7): errors and warnings q = 1 ──────────────── Error in `getJuliaExecutablePath()`: Julia not found in path. Please check your Julia setup. Backtrace: ▆ 1. ├─base::suppressWarnings(...) at test-error_warning.R:82:6 2. │ └─base::withCallingHandlers(...) 3. ├─testthat::expect_warning(...) 4. │ └─testthat:::expect_condition_matching(...) 5. │ └─testthat:::quasi_capture(...) 6. │ ├─testthat (local) .capture(...) 7. │ │ └─base::withCallingHandlers(...) 8. │ └─rlang::eval_bare(quo_get_expr(.quo), quo_get_env(.quo)) 9. ├─fwildclusterboot::boottest(...) 10. └─fwildclusterboot:::boottest.lm(...) 11. └─fwildclusterboot:::set_seed(...) 12. └─JuliaConnectoR::juliaEval("using StableRNGs") 13. └─JuliaConnectoR:::ensureJuliaConnection() 14. └─JuliaConnectoR:::startJulia() 15. └─JuliaConnectoR:::juliaConnection() 16. └─JuliaConnectoR:::runJuliaServer(multiclient = FALSE) 17. └─JuliaConnectoR:::getJuliaExecutablePath() ── Error (test-error_warning.R:745:3): error warning IV/WRE and q > 1 ────────── Error in `getJuliaExecutablePath()`: Julia not found in path. Please check your Julia setup. Backtrace: ▆ 1. ├─testthat::expect_warning(...) at test-error_warning.R:745:2 2. │ └─testthat:::expect_condition_matching(...) 3. │ └─testthat:::quasi_capture(...) 4. │ ├─testthat (local) .capture(...) 5. │ │ └─base::withCallingHandlers(...) 6. │ └─rlang::eval_bare(quo_get_expr(.quo), quo_get_env(.quo)) 7. ├─base::suppressMessages(...) 8. │ └─base::withCallingHandlers(...) 9. ├─fwildclusterboot::boottest(...) 10. └─fwildclusterboot:::boottest.ivreg(...) 11. └─fwildclusterboot:::set_seed(...) 12. └─JuliaConnectoR::juliaEval("using StableRNGs") 13. └─JuliaConnectoR:::ensureJuliaConnection() 14. └─JuliaConnectoR:::startJulia() 15. └─JuliaConnectoR:::juliaConnection() 16. └─JuliaConnectoR:::runJuliaServer(multiclient = FALSE) 17. └─JuliaConnectoR:::getJuliaExecutablePath() ── Error (test-global_vars.R:12:3): global boot_algo ─────────────────────────── Error in `getJuliaExecutablePath()`: Julia not found in path. Please check your Julia setup. Backtrace: ▆ 1. ├─base::suppressWarnings(...) at test-global_vars.R:12:2 2. │ └─base::withCallingHandlers(...) 3. ├─fwildclusterboot::boottest(...) 4. └─fwildclusterboot:::boottest.lm(...) 5. └─fwildclusterboot:::set_seed(...) 6. └─JuliaConnectoR::juliaEval("using StableRNGs") 7. └─JuliaConnectoR:::ensureJuliaConnection() 8. └─JuliaConnectoR:::startJulia() 9. └─JuliaConnectoR:::juliaConnection() 10. └─JuliaConnectoR:::runJuliaServer(multiclient = FALSE) 11. └─JuliaConnectoR:::getJuliaExecutablePath() ── Error (test-method_equivalence.R:256:3): Do different, but equivalent ways to specify linear models lead to equivalent results? ── Error in `getJuliaExecutablePath()`: Julia not found in path. Please check your Julia setup. Backtrace: ▆ 1. └─fwildclusterboot (local) create_models(clustid = "group_id1") at test-method_equivalence.R:256:2 2. ├─base::assign(...) at test-method_equivalence.R:108:6 3. ├─base::suppressWarnings(...) 4. │ └─base::withCallingHandlers(...) 5. ├─fwildclusterboot::boottest(...) 6. └─fwildclusterboot:::boottest.lm(...) 7. └─fwildclusterboot:::set_seed(...) 8. └─JuliaConnectoR::juliaEval("using StableRNGs") 9. └─JuliaConnectoR:::ensureJuliaConnection() 10. └─JuliaConnectoR:::startJulia() 11. └─JuliaConnectoR:::juliaConnection() 12. └─JuliaConnectoR:::runJuliaServer(multiclient = FALSE) 13. └─JuliaConnectoR:::getJuliaExecutablePath() ── Error (test-r-vs-julia.R:60:13): test r against Julia I: stochastic tests ─── Error in `getJuliaExecutablePath()`: Julia not found in path. Please check your Julia setup. Backtrace: ▆ 1. ├─base::suppressWarnings(...) at test-r-vs-julia.R:60:12 2. │ └─base::withCallingHandlers(...) 3. ├─fwildclusterboot::boottest(...) 4. └─fwildclusterboot:::boottest.lm(...) 5. └─fwildclusterboot:::set_seed(...) 6. └─JuliaConnectoR::juliaEval("using StableRNGs") 7. └─JuliaConnectoR:::ensureJuliaConnection() 8. └─JuliaConnectoR:::startJulia() 9. └─JuliaConnectoR:::juliaConnection() 10. └─JuliaConnectoR:::runJuliaServer(multiclient = FALSE) 11. └─JuliaConnectoR:::getJuliaExecutablePath() ── Error (test-seed.R:17:5): seed works for OLS ──────────────────────────────── Error in `getJuliaExecutablePath()`: Julia not found in path. Please check your Julia setup. Backtrace: ▆ 1. ├─base::suppressMessages(...) at test-seed.R:17:4 2. │ └─base::withCallingHandlers(...) 3. ├─fwildclusterboot::boottest(...) 4. └─fwildclusterboot:::boottest.lm(...) 5. └─fwildclusterboot:::set_seed(...) 6. └─JuliaConnectoR::juliaEval("using StableRNGs") 7. └─JuliaConnectoR:::ensureJuliaConnection() 8. └─JuliaConnectoR:::startJulia() 9. └─JuliaConnectoR:::juliaConnection() 10. └─JuliaConnectoR:::runJuliaServer(multiclient = FALSE) 11. └─JuliaConnectoR:::getJuliaExecutablePath() ── Error (test-tstat_equivalence.R:284:3): t-stat equivalence OLS ────────────── Error in `getJuliaExecutablePath()`: Julia not found in path. Please check your Julia setup. Backtrace: ▆ 1. └─fwildclusterboot (local) ols_test(run_this_test = TRUE) at test-tstat_equivalence.R:284:2 2. ├─base::suppressWarnings(...) at test-tstat_equivalence.R:78:16 3. │ └─base::withCallingHandlers(...) 4. ├─fwildclusterboot::boottest(...) 5. └─fwildclusterboot:::boottest.lm(...) 6. └─fwildclusterboot:::set_seed(...) 7. └─JuliaConnectoR::juliaEval("using StableRNGs") 8. └─JuliaConnectoR:::ensureJuliaConnection() 9. └─JuliaConnectoR:::startJulia() 10. └─JuliaConnectoR:::juliaConnection() 11. └─JuliaConnectoR:::runJuliaServer(multiclient = FALSE) 12. └─JuliaConnectoR:::getJuliaExecutablePath() ── Error (test-tstat_equivalence.R:516:3): t-stat equivalence OLS q > 1 ──────── Error in `getJuliaExecutablePath()`: Julia not found in path. Please check your Julia setup. Backtrace: ▆ 1. └─fwildclusterboot (local) wald_test(run_this_test = TRUE) at test-tstat_equivalence.R:516:2 2. ├─base::suppressWarnings(...) at test-tstat_equivalence.R:351:6 3. │ └─base::withCallingHandlers(...) 4. ├─fwildclusterboot::mboottest(...) 5. └─fwildclusterboot:::mboottest.lm(...) 6. └─fwildclusterboot:::set_seed(...) 7. └─JuliaConnectoR::juliaEval("using StableRNGs") 8. └─JuliaConnectoR:::ensureJuliaConnection() 9. └─JuliaConnectoR:::startJulia() 10. └─JuliaConnectoR:::juliaConnection() 11. └─JuliaConnectoR:::runJuliaServer(multiclient = FALSE) 12. └─JuliaConnectoR:::getJuliaExecutablePath() ── Error (test-tstat_equivalence.R:590:3): t-stat equivalence IV ─────────────── Error in `getJuliaExecutablePath()`: Julia not found in path. Please check your Julia setup. Backtrace: ▆ 1. └─fwildclusterboot (local) iv_test(run_this_test = TRUE) at test-tstat_equivalence.R:590:2 2. ├─base::suppressWarnings(...) at test-tstat_equivalence.R:560:6 3. │ └─base::withCallingHandlers(...) 4. ├─fwildclusterboot::boottest(...) 5. └─fwildclusterboot:::boottest.ivreg(...) 6. └─fwildclusterboot:::set_seed(...) 7. └─JuliaConnectoR::juliaEval("using StableRNGs") 8. └─JuliaConnectoR:::ensureJuliaConnection() 9. └─JuliaConnectoR:::startJulia() 10. └─JuliaConnectoR:::juliaConnection() 11. └─JuliaConnectoR:::runJuliaServer(multiclient = FALSE) 12. └─JuliaConnectoR:::getJuliaExecutablePath() [ FAIL 11 | WARN 12 | SKIP 0 | PASS 241 ] Error: Test failures Execution halted R CMD check generated the following check_fails: 1. no_import_package_as_a_whole 2. rcmdcheck_tests_pass 3. rcmdcheck_reasonable_installed_size #### Test coverage with [covr](https://covr.r-lib.org/) ERROR: Test Coverage Failed #### Cyclocomplexity with [cyclocomp](https://github.com/MangoTheCat/cyclocomp) The following functions have cyclocomplexity >= 15: function | cyclocomplexity --- | --- get_cluster | 36 gtools_permutations | 34 boot_algo_julia | 21 boot_algo2 | 17 getBoottest_nthreads | 16 check_boottest_args_plus | 15 #### Static code analyses with [lintr](https://github.com/jimhester/lintr) [lintr](https://github.com/jimhester/lintr) found the following 1076 potential issues: message | number of times --- | --- Avoid library() and require() calls in packages | 13 Avoid trailing semicolons, they are not needed. | 2 Avoid using sapply, consider vapply instead, that's type safe | 22 Lines should not be more than 80 characters. | 1039

5. Other Checks

Details of other checks (click to open)

:heavy_multiplication_x: The following 2 function names are duplicated in other packages: - - `model_matrix` from bayesbr, hardhat, mcmcsae, modelr, ZIprop - - `pval` from CIPerm, dostats, dostats, GUIDE, learnstats, molic, mosaic, overlapptest, RPtests, timereg

Package Versions

|package |version | |:--------|:---------| |pkgstats |0.1.1.1 | |pkgcheck |0.0.3.74 | |srr |0.0.1.151 |

Editor-in-Chief Instructions:

Processing may not proceed until the items marked with :heavy_multiplication_x: have been resolved.

mpadge commented 2 years ago

@s3alfisc This is one of our testing grounds for automated package checks. Results from your package are above, but you can see it has lots of failures because our check system doesn't install Julia. I guess we could do that, but you should at least definitely have clauses in your functions/tests to avoid calling Julia fns if it's not installed.

mpadge commented 2 years ago

@s3alfisc Let me know if you'd like a re-check via our system before you call it in the much more public main page, and i'll dump another one here for you to check first. I see you're also on our slack, so feel free to ping me there anytime with any other questions.

ropensci-review-bot commented 2 years ago

'srr' standards compliance:

:heavy_check_mark: This package complies with > 50% of all standads and may be submitted.

ropensci-review-bot commented 2 years ago

'srr' standards compliance:

:heavy_check_mark: This package complies with > 50% of all standads and may be submitted.