search

ropg / M5Core2

M5Core2 Arduino Library
MIT License
7 stars 1 forks source link

Doc error! #47

Closed vkichline closed 4 years ago

vkichline commented 4 years ago

PointAndZone.h, line 18: "Values -1 for x and y indicate an invalid value"

Yet another reason to hate magic numbers. Suggest: "The value INVALID_VALUE for x or y indicate..."

Code error? Line 155: void set(int16t x = -1, int16t y = -1); Shouldn't this be: void set(int16t x = INVALID_VALUE, int16t y = INVALID_VALUE);

ropg commented 4 years ago

yup, fixed...