DST ended early in PT - Githubissues

ropg / ezTime

ezTime — pronounced "Easy Time" — is a very easy to use Arduino time and date library that provides NTP network time lookups, extensive timezone support, formatted time and date strings, user events, millisecond precision and more.

MIT License

327 stars 92 forks source link

DST ended early in PT #15

Closed acortelyou closed 5 years ago

acortelyou commented 5 years ago

I noticed that DST ended early in my time zone on version 0.7.7.

Possibly related to #11?

Using setLocation("America/Los_Angeles"):

Date	Time	ezTime
NOV 3	11:00PM	10:00PM
NOV 4	12:00AM	11:00PM
NOV 4	1:00AM	12:00AM
NOV 4	1:00AM	1:00AM
NOV 4	2:00AM	2:00AM

ropg commented 5 years ago

Drats... I can see it started showing the right time at 1 AM, but I can't from your table see when it started showing the wrong time. Will figure this out tomorrow...

acortelyou commented 5 years ago

To clarify: the time indicated by ezTime was linear for the duration and only became correct as DST ended and the actual time changed to match.

Unfortunately I do not know when ezTime became incorrect initially nor if this behavior was introduced with 0.7.7.

ropg commented 5 years ago

I believe this is fixed by the fix for #38, my makeOrdinalTime function was off when the last of a given weekday in a given month was requested. Please reopen if problem reoccurs.