search

ropg / ezTime

ezTime — pronounced "Easy Time" — is a very easy to use Arduino time and date library that provides NTP network time lookups, extensive timezone support, formatted time and date strings, user events, millisecond precision and more.
MIT License
336 stars 93 forks source link

Timezone definition incorrect #43

Closed agoston closed 5 years ago

agoston commented 5 years ago

Hi,

Awesome library, however, this week, a bug was revealed in timezone config. In the README.md, and also in your lookup server, it is stated that timezone for Berlin/western eu is:

CET-1CEST,M3.4.0/2,M10.4.0/3

However, the actual definition is 'last sunday of the month'. In march 2019, the month had 5 sundays, so the clock on my night table is off for an hour this week.

According to the spec, '5' means 'last of the month', so I've also took the liberty to update the definition in my code to

CET-1CEST,M3.5.0/2,M10.5.0/3

Can you update README.md and probably your server accordingly?

ropg commented 5 years ago

If you upgrade to 0.7.10, you'll likely notice the problem is fixed...

ropg commented 5 years ago

Fixed the documentation now also...

agoston commented 5 years ago

drat, i did check the commits, but missed the "last week patch" comment, sorry. Good to know it's fixed, thanks!