bug where timezones not observing DST were incorrectly translated - Githubissues

ropg / ezTime

ezTime — pronounced "Easy Time" — is a very easy to use Arduino time and date library that provides NTP network time lookups, extensive timezone support, formatted time and date strings, user events, millisecond precision and more.

MIT License

327 stars 92 forks source link

bug where timezones not observing DST were incorrectly translated #70

Closed johnslemmer closed 4 years ago

johnslemmer commented 4 years ago

Timezones like Pacific/Honolulu and America/Phoenix (and probably others) do not observe DST. They always stay on their standard time.

The current code essentially treated all calls to tzTime in this time zone like the timestamp t was a UTC timestamp (subtracting the the offset). However, this is incorrect and should be able to translate both ways depending on what local_or_utc is set to.

See https://github.com/ropg/ezTime/blob/master/src/ezTime.cpp#L752 for the bug.

PR coming soon for the fix.

ropg commented 4 years ago

That bit of code looks confused indeed. Thanks! Will wait for Pull Request...