search

ropg / heltec_esp32_lora_v3

Proper working Arduino library for the Heltec ESP32 LoRa v3 board, as well as for Wireless Stick v3 and Wireless Stick Lite v3. Uses RadioLib
MIT License
330 stars 16 forks source link

Update heltec_unofficial.h #43

Closed Genaker closed 2 weeks ago

Genaker commented 2 weeks ago

Custom PIN value for PROG button.

Boards T190, E230 have different PIN numbers - 21

It would be nice to make it redefinable.

ropg commented 2 weeks ago

I agree this is a nice thing to be able to do. The proper way is probably to make it more generic, also applying it to the other pins, but this doesn't hurt to have in there until then.

Genaker commented 2 weeks ago

Could you please merge? It will add support for the E290 and T170 boards. The only difference is that you will need to disable display and use your own library.

On Tue, Sep 10, 2024 at 3:45 AM Rop Gonggrijp @.***> wrote:

I agree this is a nice thing to be able to do. The proper way is probably to make it more generic, also applying it to the other pins, but this doesn't hurt to have in there until then.

— Reply to this email directly, view it on GitHub https://github.com/ropg/heltec_esp32_lora_v3/pull/43#issuecomment-2340315457, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACGJNZQ6AQ2TK4MH5EYVKWLZV3EVXAVCNFSM6AAAAABN5J2H3SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBQGMYTKNBVG4 . You are receiving this because you authored the thread.Message ID: @.***>

Genaker commented 2 weeks ago

Thanks!