roq-messaging / RoQ

RoQ, Elastically scalable MOM
21 stars 4 forks source link

Fix maven pom.xml files #154

Closed ahderman closed 10 years ago

ahderman commented 10 years ago

mvn install did not work, so I fixed the pom.xml files.

jbruggem commented 10 years ago

Could you please elaborate on the reasons of your changes, for posterity?

ahderman commented 10 years ago

I would like someone to reproduce it. It takes all of 5 minutes.

I started by cleaning up the maven repository (rm -rf ~/.m2/repository/org/roqmessaging/).

Running mvn install -DskipTests with revision 1338bc61cf66ff13a3f26ad61f6618f53710f957 stops on errors such as:

[ERROR] BUILD ERROR
[INFO] ------------------------------------------------------------------------
[INFO] Failed to resolve artifact.

Missing:
----------
1) org.roqmessaging:roq-clientlib:jar:1.0-SNAPSHOT
...
  Path to dependency: 
    1) org.roqmessaging.core:roq-core:jar:1.1
    2) org.roqmessaging:roq-clientlib:jar:1.0-SNAPSHOT

----------
1 required artifact is missing.

for artifact: 
  org.roqmessaging.core:roq-core:jar:1.1

Then, if we add version numbers to the various artifacts in the pom.xml files, another error pops up about roq-scaling.

[ERROR] BUILD ERROR
[INFO] ------------------------------------------------------------------------
[INFO] Failed to resolve artifact.

Missing:
----------
1) org.roqmessaging.core:roq-scaling:jar:1.0-SNAPSHOT
...
  Path to dependency: 
    1) org.roqmessaging:roq-simulation:jar:1.0-SNAPSHOT
    2) org.roqmessaging.core:roq-scaling:jar:1.0-SNAPSHOT

----------
1 required artifact is missing.

for artifact: 
  org.roqmessaging:roq-simulation:jar:1.0-SNAPSHOT

Since revision 65f1cccc8af14389dadf0eb2bf8d688522cbe704 seems to remove roq-scaling from the top-level pom.xml but not from the roq-simulation one, I felt it was just an oversight. Commenting-out the roq-scaling dependency from roq-simulation solves the problem.

sskhiri commented 10 years ago

OK, that looks good!