search

ror-community / ror-roadmap

Central information about what is happening at ROR and how to contribute feedback
10 stars 1 forks source link

[BUG] API requests with multiple filters fail if there is an additional filter after country.country_name #142

Closed lizkrznarich closed 1 year ago

lizkrznarich commented 1 year ago

Describe the bug Requests with multiple filters that have 1 or more filters after a country.country_name filter fail with error {"errors":["filter key '' is illegal"]}

To Reproduce Run the following requests 

https://api.ror.org/organizations?filter=status:Active,country.country_name:Germany,types:Company
https://api.ror.org/organizations?filter=country.country_code:DE,types:Company,status:Active
https://api.ror.org/organizations?filter=country.country_name:Germany,types:Company

Expected behavior Requests return a 200 response and a results list

Screenshots If applicable, add screenshots to help explain your problem.

Additional context Likely due to special handling of commas in country.country_name filters because some countries have commas in their names.

lizkrznarich commented 1 year ago

https://github.com/ror-community/ror-api/pull/292