search

ror-community / ror-roadmap

Central information about what is happening at ROR and how to contribute feedback
10 stars 1 forks source link

[BUG] Validation suite doesn't catch duplicate relationships #143

Closed lizkrznarich closed 1 year ago

lizkrznarich commented 1 year ago

Describe the bug It's possible to deploy records with multiple instance of the exact same relationship because the validation suite does not check this. The create_relationships script does not allow duplicates, however, if relationships are added/edited outside of this script, it's possible to introduce duplicates.

To Reproduce Steps to reproduce the behavior:

  1. Add/edit a duplicate relationship in a record without using the create_relationships script
  2. Run validation
  3. Validation will pass and record can be deployed

Expected behavior Validation should fail if a record contains multiple relationships with the same label and type.

lizkrznarich commented 1 year ago

https://github.com/ror-community/validation-suite/pull/15