search

ror-community / ror-roadmap

Central information about what is happening at ROR and how to contribute feedback
10 stars 1 forks source link

[BUG] Validation allows duplicate relationships between two records #174

Open adambuttrick opened 1 year ago

adambuttrick commented 1 year ago

Describe the bug The existing relationship validation allows for multiple relationships of different types between two records.

To Reproduce Steps to reproduce the behavior:

  1. Create a duplicate relationship of a different type between two records
  2. Run records through validation
  3. Records validate

Expected behavior Validation should fail when a duplicate relationship of the same or different types is present in a record. Parent, Child, Related should never be duplicated for a related ID on a record, but its possible that one of those plus successor/predecessor is valid (but should still probably be flagged for sanity’s sake).

lizkrznarich commented 1 year ago

@adambuttrick Is this still actually a problem? It should have been fixed on https://github.com/ror-community/ror-roadmap/issues/143. If it's not fixed, can you provide an example that passed when it should have failed?

adambuttrick commented 1 year ago

@lizkrznarich It's still an issue. It happened in the last release. I'll contrive an example and link to it here.