ror-community / ror-roadmap

Central information about what is happening at ROR and how to contribute feedback
11 stars 2 forks source link

[MAINTENANCE] Return custom status/message for requests blocked by rate limit #222

Closed lizkrznarich closed 9 months ago

lizkrznarich commented 9 months ago

Service/repository

Describe the current state/issue Currently, when a request is blocked by rate limiting, we return the default WAF response code 403 and message Forbidden. This does not make it clear to users that they have been blocked by rate-limiting.

Describe the desired state/solution Add a custom response to the WAF rule, using the appropriate code/message 429 Too many requests.

Additional notes See AWS WAF docs https://docs.aws.amazon.com/waf/latest/developerguide/customizing-the-response-for-blocked-requests.html

lizkrznarich commented 9 months ago

https://github.com/ror-community/new-deployment/pull/165 https://github.com/ror-community/new-deployment/pull/166 https://github.com/ror-community/new-deployment/pull/167 https://github.com/ror-community/new-deployment/pull/168 https://github.com/ror-community/new-deployment/pull/169