search

ror-community / ror-roadmap

Central information about what is happening at ROR and how to contribute feedback
10 stars 2 forks source link

[BUG] Favicon missing in ROR search app #228

Closed amandafrench closed 3 weeks ago

amandafrench commented 8 months ago

Describe the bug I'm getting broken link reports for the path https://ror.org/favicon.ico on the ROR search app and individual ROR records. The correct path on the ROR website is https://ror.org/img/favicon.ico

To Reproduce Steps to reproduce the behavior:

  1. Go to https://ror.org/search or an individual record such as https://ror.org/03zsq2967
  2. No favicon appears in the browser tab (at least not on Mac Firefox or Chrome) 
<link rel="shortcut icon" href="[/favicon.ico](view-source:https://ror.org/favicon.ico)" type="image/x-icon">
 <link rel="icon" href="[/favicon.ico](view-source:https://ror.org/favicon.ico)" type="image/x-icon">

Expected behavior See a favicon in the browser tab

Screenshots Compare favicon in tab on ror.org vs. on ror.org/search

Screenshot 2024-03-11 at 1 33 43 PM

Device information:

amandafrench commented 3 weeks ago

Fixed in https://github.com/ror-community/ror-app/pull/206