search

ror-community / ror-roadmap

Central information about what is happening at ROR and how to contribute feedback
10 stars 2 forks source link

[BUG] v2 API: Language code not included for some names in new records creat via CSV bulk update #234

Closed lizkrznarich closed 2 months ago

lizkrznarich commented 5 months ago

Version v2

Describe the bug When creating new records from a CSV, if the same name value/language is included in names.types.ror_display and names.types.label, the lang code is omitted from the resulting names object even if a language exists in the CSV.

To Reproduce Steps to reproduce the behavior:

  1. Create a CSV with a row for a new record that has a name with the same value/language in names.types.ror_display and names.types.label . Each name should have a language
  2. Post the file to /bulkupdate
  3. Downloads zip file from S3
  4. Corresponding record file contains name object with correct value and types but no language code.

Expected behavior Language code is included in name object

lizkrznarich commented 5 months ago

https://github.com/ror-community/ror-api/pull/391