search

ror-community / ror-roadmap

Central information about what is happening at ROR and how to contribute feedback
10 stars 2 forks source link

[BUG] Error handling in /bulkupdate for case where name values incorrectly contains multiple * #239

Closed lizkrznarich closed 2 months ago

lizkrznarich commented 6 months ago

Version v2

Describe the bug When creating/updating records from a CSV using the /bulkcreate endpoint, if a name field contains value with multiple * chars (which as used as language delimiters), the entire request fails with a 500 error instead of recording an error message in the report CSV.

To Reproduce Steps to reproduce the behavior:

  1. Create a CSV with a value in one of the names.types.XXX fields that contains multiple chars (ex `ខេមអែដខេមអែដ*km`)
  2. Post the file to /v2/bulkupdate?validate or /v2/bulkupdate
  3. Response <h1>Server Error (500)</h1> is returned

*Expected behavior For /v2/bulkupdate?validate, response should be a CSV report with an error message for the row with the invalid name For /v2/bulkupdate, response should be success msg with a link to a zip file in S3. report.csv inside the file should indicate that the row with the invalid name was skipped, along with an error msg

lizkrznarich commented 6 months ago

https://github.com/ror-community/ror-api/pull/397

lizkrznarich commented 2 months ago

https://github.com/ror-community/ror-api/pull/397