ror-community / ror-roadmap

Central information about what is happening at ROR and how to contribute feedback
10 stars 2 forks source link

[BUG] v2->v1 conversion removes Funder IDs from records #255

Closed adambuttrick closed 2 months ago

adambuttrick commented 4 months ago

Version v2

Describe the bug The v2->v1 conversion script is removing Funder IDs from records when converting from v2 to v1 format.

To Reproduce Steps to reproduce the behavior:

  1. Compare the following v2 and v1 record files for ROR ID 05mmh0f86:
  2. Observe that Funder IDs are present in the v2 file but missing in the v1 files committed after the conversion script is ran.
  3. Compare the same record using the v1 and v2 versions of the API:
  4. Confirm that Funder IDs are missing in the v1 API response:

Expected behavior Funder IDs should be preserved when converting from v2 to v1 format.

lizkrznarich commented 2 months ago

https://github.com/ror-community/curation_ops/commit/f9806a70a253f99ccb137a8b081a424815668ca4