search

roramirez / MMM-ImagesPhotos

Show images and photos in your MagicMirror
MIT License
45 stars 17 forks source link

Update README.md #6

Closed mykle1 closed 7 years ago

mykle1 commented 7 years ago

I changed width to maxWidth and heigth to maxHeight in the config options and some small grammatical errors. I hope you don't mind. I love this module!

roramirez commented 7 years ago

Great!, which one of all Pull Request is valid?

Also, it is need change the variable into the module not only the README and add backward compatibility for behavior of the configuration.

roramirez commented 7 years ago

Sorry @mykle1

All this is my mistake. I can see your Pull Request is OK. I was thinking the option in module is called like width and heigth.

This close #1

Thanks @mykle1

mykle1 commented 7 years ago

On 3/15/2017 5:21 PM, Rodrigo Ramírez Norambuena wrote:

Great!, which one of all Pull Request is valid?

The last one. Sorry about that. I was having some issues with my computer when I was editing so I didn't know if the edits were going through. So the last pull request is the correct one.

Also, it is need change the variable into the module not only the README and add backward compatibility for behavior of the configuration.

The module does not need to be changed. The module works with my changes, maxWidth: and maxHeight: in the config.js. - maxWidth: "100%", and maxHeight: "100%", are already set in the main js file.

Only the readMe was incorrect.

Thank you

Mykle

mykle1 commented 7 years ago

Oh, I just sent you an email.

Thanks for the wonderful module!

Mykle

On 3/15/2017 9:25 PM, Rodrigo Ramírez Norambuena wrote:

Sorry @mykle1 https://github.com/mykle1

All this is my mistake. I can see your Pull Request is OK. I was thinking the option in module is called like width and heigth.

This close #1 https://github.com/roramirez/MMM-ImagesPhotos/issues/1

Thanks @mykle1 https://github.com/mykle1

cowboysdude commented 7 years ago

Thanks for a great catch guys!

roramirez commented 7 years ago

Merged!

mykle1 commented 7 years ago

Cool, thanks!

On 3/15/2017 9:34 PM, Rodrigo Ramírez Norambuena wrote:

Merged!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/roramirez/MMM-ImagesPhotos/pull/6#issuecomment-286931580, or mute the thread https://github.com/notifications/unsubscribe-auth/AYCznM7wDboi9VdBY2nkTzEnud4dsb4Xks5rmJG6gaJpZM4MeauT.

No virus found in this message. Checked by AVG - www.avg.com http://www.avg.com/email-signature Version: 2016.0.8007 / Virus Database: 4756/14121 - Release Date: 03/15/17