[BUG] MRIcroGL shows wrong path when hovering over overlays.

rordenlab / MRIcroGL

v1.2 GLSL volume rendering. Able to view NIfTI, DICOM, MGH, MHD, NRRD, AFNI format images.

https://www.nitrc.org/plugins/mwiki/index.php/mricrogl:MainPage

Other

207 stars 33 forks source link

[BUG] MRIcroGL shows wrong path when hovering over overlays. #59

Closed TamerGezici closed 1 year ago

TamerGezici commented 1 year ago

When you hover over an overlay at the top-left overlay list, the wrong path/name is presented for the first time you hover over it. You must unhover and hover again and again until it gets the correct one.

Steps to reproduce:

Load your background image.
Load 2 overlay images.
Hover over the first overlay name on the top-left overlay list and see the path at the pop up text.
Hover over the second overlay name and notice the first path is presented.
Hover over the second overlay name again and again until it presents the correct path.

TamerGezici commented 1 year ago

Noting that it is a minor bug and the possibility of the developers being preoccupied with more important things, I wanted to see where the dialog popped up to (maybe) trying to fix it myself and it seems like it's here:

https://github.com/rordenlab/MRIcroGL/blob/c2f3b6f18128ea7f802179c61bf116973711af1d/mainunit.pas#L8664C1-L8674C5

However, I am not so sure where the variable niftiVol.Filename is set and why it does not immediately update.

neurolabusc commented 1 year ago

Will be addressed in future release. While I am glad that MRIcroGL has proven popular and robust, my primary development focus is on NiiVue so do not expect a rapid resolution.

neurolabusc commented 1 year ago

The problem and solution is described here. The OnShowHint event is fired as the event is shown, so setting the hint with this event means that the updated hint will be shown the next time the event is fired. The solution is to set the hint on the OnMouseEnter event, prior to when the hint is displayed.