Closed marcelzwiers closed 1 year ago
Acknowledged. With the Windows operating system pigz.exe must be in the current working directory to be detected. This will be fixed in a future release.
@marcelzwiers can you test that the latest development build (v1.0.20221120) fixes your issue? Compiling on Windows is a bit tricky, so you can download the pre-compiled executable by going to the AppVeyor web page and clicking on the Artifacts
button.
Still the same (I unzipped the AppVeypor files in the Resources folder) :-(
C:\Users\Marcel>set "PATH=%PATH%;C:\Program Files\MRIcroGL\Resources"
C:\Users\Marcel>dcm2niix -v
Compression will be faster with C:\Users\Marcel\pigz.exe in the same folder as the executable
Chris Rorden's dcm2niiX version v1.0.20221120 (JP2:OpenJPEG) (JP-LS:CharLS) MSC1900 (64-bit Windows)
v1.0.20221120
Unable to replicate. It appears that the copy of dcm2niix in the path C:\Users\Marcel\dcm2niix
is taking precedence over the copy in ';C:\Program Files\MRIcroGL\Resources\dcm2niix'. You could either explicitly run the latter or copy pigz to the folder C\Users\Marcel
Mhhh, I don't think it did?
C:\Users\Marcel>dcm2niix -v
'dcm2niix' is not recognized as an internal or external command,
operable program or batch file.
C:\Users\Marcel>set "PATH=%PATH%;C:\Program Files\MRIcroGL\Resources"
C:\Users\Marcel>dcm2niix -v
Compression will be faster with C:\Users\Marcel\pigz.exe in the same folder as the executable
Chris Rorden's dcm2niiX version v1.0.20221120 (JP2:OpenJPEG) (JP-LS:CharLS) MSC1900 (64-bit Windows)
v1.0.20221120
C:\Users\Marcel>where dcm2niix
C:\Program Files\MRIcroGL\Resources\dcm2niix.exe
C:\Users\Marcel>where pigz
C:\Program Files\MRIcroGL\Resources\pigz.exe
Did you try providing the working directory with your call?
"C:\Program Files\MRIcroGL\Resources\dcm2niix.exe"
That works!
C:\Users\Marcel>C:\"Program Files"\MRIcroGL\Resources\dcm2niix -v
Chris Rorden's dcm2niiX version v1.0.20221120 (JP2:OpenJPEG) (JP-LS:CharLS) MSC1900 (64-bit Windows)
v1.0.20221120
Why don't you try the latest commit (v1.0.20221122). I try to use the GetModuleFileName function if pigz is not in the current working directory and the location of dcm2niix can not be determined from the first argument. I did not test for MinGW compilation, so we might need to wrap the new code in a #ifdef _MSC_VER
conditional.
Yes, it all works now :-)
C:\Users\Marcel>C:\"Program Files"\MRIcroGL\Resources\dcm2niix -v
Chris Rorden's dcm2niiX version v1.0.20221121 (JP2:OpenJPEG) (JP-LS:CharLS) MSC1900 (64-bit Windows)
v1.0.20221121
C:\Users\Marcel>set "PATH=%PATH%;C:\Program Files\MRIcroGL\Resources"
C:\Users\Marcel>dcm2niix -v
Chris Rorden's dcm2niiX version v1.0.20221121 (JP2:OpenJPEG) (JP-LS:CharLS) MSC1900 (64-bit Windows)
v1.0.20221121
Describe the bug
Pigz.exe is on the windows path but dcm2niix can't find it
To reproduce
Steps to reproduce the behavior:
The pigz executable, however, is present in the same folder:
Expected behavior
I don't expect that pigz warning message
Version
v1.0.20220720 (see also above)