search

rorist / android-network-discovery

Android network tool: Discover hosts and scan their ports, in your Wifi/3G network.
http://rorist.github.com/android-network-discovery/
587 stars 242 forks source link

Some UI tweaks #1

Closed ge0rg closed 13 years ago

ge0rg commented 13 years ago

Hi, I have made some tweaks to the user interface, to make it more consistent with Android UX:

I also removed local.preferences from the git repo, as it should not be in source control. Please backup your file before merging :)

rorist commented 13 years ago

Hi there,

I just applied two patches from your branch. I didn't apply the long-press changes because I think that way the user would miss the "change name" option. Plus, I think it's better not to run the port scan without a prompt.

Anyway, thanks a lot for your interest and do not hesitate to contribute more. I'll work on the software again this summer after I finished my study. So it will be more active again. There is a lot of work in the port scanner and the discovery as well. I have to push some changes I already made using ARP requests to discover devices instead of ping scan.

Regards Aubort Jean-Baptiste

On Sat, May 28, 2011 at 01:21, ge0rg reply@reply.github.com wrote:

Hi, I have made some tweaks to the user interface, to make it more consistent with Android UX:

 * when you click on a host, a port scan is initiated directly (main action).  * when you long-press a host, the menu is displayed  * when you change the name of a host, it is updated in the activity

I also removed local.preferences from the git repo, as it should not be in source control. Please backup your file before merging :)

Reply to this email directly or view it on GitHub: https://github.com/rorist/android-network-discovery/pull/1

ge0rg commented 13 years ago

Thanks for your good work, I am eager to test new functionality.

Regarding the long-press patch, I have had the same hesitations, so its OK if you keep it out. It just feels more natural to me this way ;-)