search

rorodata / rorocloud

Command-line interface to rorocloud service.
Apache License 2.0
0 stars 2 forks source link

Check for errors in response from rorocloud in _request method. #3

Closed sohail535 closed 7 years ago

sohail535 commented 7 years ago 
$ rorocloud run echo hello
Traceback (most recent call last):
  File "/home/sohail/rorodata/rorocloud/venv/bin/rorocloud", line 11, in <module>
    load_entry_point('rorocloud', 'console_scripts', 'rorocloud')()
  File "/home/sohail/rorodata/rorocloud/rorocloud/cli.py", line 187, in main
    cli()
  File "/home/sohail/rorodata/rorocloud/venv/lib/python3.5/site-packages/click/core.py", line 722, in __call__
    return self.main(*args, **kwargs)
  File "/home/sohail/rorodata/rorocloud/venv/lib/python3.5/site-packages/click/core.py", line 697, in main
    rv = self.invoke(ctx)
  File "/home/sohail/rorodata/rorocloud/venv/lib/python3.5/site-packages/click/core.py", line 1066, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/sohail/rorodata/rorocloud/venv/lib/python3.5/site-packages/click/core.py", line 895, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/sohail/rorodata/rorocloud/venv/lib/python3.5/site-packages/click/core.py", line 535, in invoke
    return callback(*args, **kwargs)
  File "/home/sohail/rorodata/rorocloud/rorocloud/cli.py", line 70, in run
    _run(command, shell=shell, workdir=workdir, foreground=foreground)
  File "/home/sohail/rorodata/rorocloud/rorocloud/cli.py", line 73, in _run
    job = client.run(command, shell=shell, workdir=workdir)
  File "/home/sohail/rorodata/rorocloud/rorocloud/client.py", line 88, in run
    return Job(data)
  File "/home/sohail/rorodata/rorocloud/rorocloud/client.py", line 109, in __init__
    self.id = data['jobid']
KeyError: 'jobid'

Any command that is run in rorocloud is not checking for an error response from rorocloud. I ran the above command after removing ~/.rorocloudrc

anandology commented 7 years ago

I think the _request method should return the response object and each method calling it should check the status code and raise appropriate error message.

On Tue, Jun 6, 2017 at 5:02 PM, sohail535 notifications@github.com wrote:

$ rorocloud run echo hello Traceback (most recent call last): File "/home/sohail/rorodata/rorocloud/venv/bin/rorocloud", line 11, in load_entry_point('rorocloud', 'console_scripts', 'rorocloud')() File "/home/sohail/rorodata/rorocloud/rorocloud/cli.py", line 187, in main cli() File "/home/sohail/rorodata/rorocloud/venv/lib/python3.5/site-packages/click/core.py", line 722, in call return self.main(args, kwargs) File "/home/sohail/rorodata/rorocloud/venv/lib/python3.5/site-packages/click/core.py", line 697, in main rv = self.invoke(ctx) File "/home/sohail/rorodata/rorocloud/venv/lib/python3.5/site-packages/click/core.py", line 1066, in invoke return _process_result(sub_ctx.command.invoke(sub_ctx)) File "/home/sohail/rorodata/rorocloud/venv/lib/python3.5/site-packages/click/core.py", line 895, in invoke return ctx.invoke(self.callback, ctx.params) File "/home/sohail/rorodata/rorocloud/venv/lib/python3.5/site-packages/click/core.py", line 535, in invoke return callback(args, **kwargs) File "/home/sohail/rorodata/rorocloud/rorocloud/cli.py", line 70, in run _run(command, shell=shell, workdir=workdir, foreground=foreground) File "/home/sohail/rorodata/rorocloud/rorocloud/cli.py", line 73, in _run job = client.run(command, shell=shell, workdir=workdir) File "/home/sohail/rorodata/rorocloud/rorocloud/client.py", line 88, in run return Job(data) File "/home/sohail/rorodata/rorocloud/rorocloud/client.py", line 109, in init self.id = data['jobid'] KeyError: 'jobid'

Any command that is run in rorocloud is not checking for an error response from rorocloud.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/rorodata/rorocloud/issues/3, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAdkTtXUX6yooTusM5FrZfrBWBW3lu-ks5sBTjlgaJpZM4NxNua .